V4 separate DWH data source connection#2356
Merged
Merged
Conversation
…2352) * Added create_table to sql_ast * Added insert into statements to sql_ast * Added newlines to new statements so it's more readable * Updated some sql ast stuff based on needs from soda-extensions * Added drop table to the AST * Code style updates * Allow insert into using select statements * Allow insert into using select statements * Implemented PR feedback --------- Co-authored-by: Paul Teehan <paul.teehan+1@gmail.com>
* First passing test for Oracle (still WIP) * Removed quote_identifier and replaced it with the dialect function (more consistency) * Fixed issues with date/time tests * Fixed issue with COUNT(DISTINCT(col1, col2, col3)) * Fix issue with schema not comparing against correct result * Added regex_advanced check in dialect. Updated tests accordingly * Updated connections for SQL Server * Update to CI * Update to CI * Updates to code quality and CI * Code quality improvements * Removed login timeout for testing * Fixed issue with active directory authentication having USER as a required field all the time * PLATL-121 - Refactor v4 CI pipeline for conditional services * Implemented synapse datasource on top of sqlserver * Fix env variable for databricks database * Fix data type mappings for databricks tests * lower case data types * let's do it like BigQuery * use string instead of varchar for text * no variable string length in sql dialect * rename modules to module in matrix * Add SQLserver service * Added extra check for row counts in test tables * Extra test for sql server that checks for activedirectory pydantic issues * Fixed table creation/row insertion issues for synapse testing tables * Reverted change for row count verification * Re-enabled row count check in `ensure_test_table` * Potential fix for drop schema for sqlserver in CI * Code quality fixes * Only drop table for sqlserver CI fix * Refactor to support soda-extensions * Revert WIP * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed datepart issue with Synapse * Added Synapse connection tests * data type test fixes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Refactoring of testdatatypes to DBDataType. Also removed length as a default from the data types (should now explicitly set it!) * More fixes for BigQuery and postgres. Changed textcol to use contract_dict. * Code quality fix * Updated test datatypes for sqlserver (and synapse) * Add Synapse CI * Update version for sqlserver and synapse * Attempt to fix sqlserver dependency in synapse CI * Attempt to fix synapse CI connection * Removed port for Synapse CI * Updated logic for dropping the schema * Only drop schema when there are tables in it * Updated logic for SQL Server as well * Changes to Synapse code for soda-extensions * Added create_table to sql_ast * Added insert into statements to sql_ast * Added newlines to new statements so it's more readable * Updated some sql ast stuff based on needs from soda-extensions * Updated sqlserver and synapse to use new ast for create and insert * Added drop table to the AST * Added drop table ast to sqlserver * Code style updates * Updated insert table code for synapse to use new AST * Updated base insert function to use new AST. * Updated autocommit logic to reflect soda-library * Updated rowcount verification for tests to be consistent with library * Updated implementation for data source specs to be more consistent with library (i.e. removed autocommit * Updates to drop_schema_if_exists based on PR feedback * Created encode utilty function * Added query_existing_test_tables function to return fully qualified names * Removed pyodbc from synapse setup.py --------- Co-authored-by: Daniel Kühne <daniel.kuhne@soda.io> Co-authored-by: Michael Van de Steene <michael.vandesteene@hotmail.com> Co-authored-by: Paul Teehan <paul.teehan+1@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Added query one by one on data source connection * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Got rid of the explicit error handling by using a context manager --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
nielsn
marked this pull request as ready for review
August 4, 2025 13:04
nielsn
self-requested a review
August 4, 2025 13:04
nielsn
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.