Attachment unit test cases in SODA API pkg/controller#1287
Open
nguptaopensds wants to merge 4 commits into
Open
Attachment unit test cases in SODA API pkg/controller#1287nguptaopensds wants to merge 4 commits into
nguptaopensds wants to merge 4 commits into
Conversation
nguptaopensds
force-pushed
the
test_attach
branch
from
52b2d2d to
1574990
Compare
Contributor
Author
|
@NajmudheenCT please check once |
nguptaopensds
force-pushed
the
test_attach
branch
from
4525ce3 to
7195ca7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1287 +/- ##
==========================================
- Coverage 41.48% 39.36% -2.13%
==========================================
Files 53 53
Lines 7752 6966 -786
==========================================
- Hits 3216 2742 -474
+ Misses 4021 3692 -329
- Partials 515 532 +17 🚀 New features to boost your workflow:
|
kumarashit
reviewed
Jun 18, 2020
| }`) | ||
| var expected model.VolumeAttachmentSpec | ||
| json.Unmarshal(expectedJson, &expected) | ||
| fmt.Println(expected) |
Collaborator
There was a problem hiding this comment.
If this is for debugging, please remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
This PR is adding the unit test cases for attachment.go in pkg/controller
Which issue(s) this PR fixes:
Fixes #
Test Report Added?:
Test Report:
Special notes for your reviewer: