Adding File share unit test cases,coverage > 50%#1295
Open
nguptaopensds wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1295 +/- ##
==========================================
- Coverage 41.48% 40.58% -0.91%
==========================================
Files 53 53
Lines 7752 6966 -786
==========================================
- Hits 3216 2827 -389
+ Misses 4021 3574 -447
- Partials 515 565 +50 🚀 New features to boost your workflow:
|
nguptaopensds
changed the title
nguptaopensds
changed the title
nguptaopensds
changed the title
kumarashit
reviewed
Jun 20, 2020
| assertTestResult(t, w.Code, 202) | ||
| }) | ||
|
|
||
| t.Run("Should return 500 if delete file share snapshot with bad request", func(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
Why Bad request is 500 error? Should it not be 400?
Contributor
Author
There was a problem hiding this comment.
I will check once, may be we need to change main code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Added test case for create file share in pkg/controller package
Which issue(s) this PR fixes:
Fixes #1270
Test Report Added?:
/kind TESTED
Test Report:
Special notes for your reviewer: