-
Notifications
You must be signed in to change notification settings - Fork 526
3.1.x file not exsist #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.1.x
Are you sure you want to change the base?
3.1.x file not exsist #1102
Conversation
|
Hi @LuotuoMianyang, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| } | ||
| if (jarLocation.startsWith("file:")) { | ||
| jarLocation = jarLocation.substring("file:".length()); | ||
| if (!jarLocation.endsWith(JAR_UNPACK)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
master代码里面似乎之前针对这里做过一些处理,针对.jar 为结尾的jarLocation做的处理
上述问题发生时机为安装biz的时候,默认会选择unpack,从unpack中加载资源,2.1 之前没有问题,3.x中新增了截图中的逻辑,但是unpakc的路径 是jar_unpack_XX ,导致找资源失败,从而导致安装biz模块失败,这里是加载biz模块的逻辑,失败了再做其他处理也没什么意义,可以看看master中 有
if (jarLocation.contains(JAR_SUFFIX)) { jarLocation = jarLocation.substring(0, jarLocation.lastIndexOf(JAR_SUFFIX) + JAR_SUFFIX.length()); }
这样的逻辑是否合理
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
master代码里面似乎之前针对这里做过一些处理,针对.jar 为结尾的jarLocation做的处理
上述问题发生时机为安装biz的时候,默认会选择unpack,从unpack中加载资源,2.1 之前没有问题,3.x中新增了截图中的逻辑,但是unpakc的路径 是jar_unpack_XX ,导致找资源失败,从而导致安装biz模块失败,这里是加载biz模块的逻辑,失败了再做其他处理也没什么意义,可以看看master中 有
if (jarLocation.contains(JAR_SUFFIX)) { jarLocation = jarLocation.substring(0, jarLocation.lastIndexOf(JAR_SUFFIX) + JAR_SUFFIX.length()); }
这样的逻辑是否合理

Motivation
问题描述 在使用 SOFAArk 3.1.10 和 Spring Boot 3.2.1 时,安装 declaredMode=true 的 biz 模块时出现 File must exist 错误。错误发生在 biz 模块启动 Spring Boot 应用时,SOFAArk 的 parseArtifactId() 方法尝试访问已被删除的原始 JAR 文件。
关联issue:
#1101
Modification
Describe the idea and modifications you've done.
Result
Resolved or fixed #<1101>.
If there is no issue then describe the changes introduced by this PR.