Upgrade spring boot version to 3.4.4 #1365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Walkthrough
The pull request updates the Spring Boot dependency version within the `pom.xml` file. Both the `<parent>` version and the `<spring.boot.version>` property have been revised from `3.3.7` to `3.4.4`. Additionally, it adds the class `org.springframework.boot.actuate.ssl.SslHealthIndicator` to the list of default excluded health indicators in the `HealthIndicatorProcessor` class. The GitHub Actions workflow was also updated to run on Ubuntu 22.04 instead of Ubuntu 20.04. Furthermore, the Spring Cloud version property in the `sofaboot-dependencies/pom.xml` was updated from `2023.0.3` to `2024.0.0`.
## Changes
| File | Changes |
|---------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------|
| pom.xml | Updated Spring Boot dependency: parent version and `<spring.boot.version>` from 3.3.7 to 3.4.4 |
| sofa-boot-project/sofa-boot-actuator/src/main/java/com/alipay/sofa/boot/actuator/... | Added `org.springframework.boot.actuate.ssl.SslHealthIndicator` to the default excluded health indicators list |
| .github/workflows/maven.yml | Changed GitHub Actions runner environment from Ubuntu 20.04 to Ubuntu 22.04 |
| sofa-boot-project/sofaboot-dependencies/pom.xml | Updated Spring Cloud version property from `2023.0.3` to `2024.0.0` |
## Possibly related PRs
- sofastack/sofa-boot#1326: Updates Spring Boot version in `pom.xml` and related properties, similar dependency upgrade scope.
- sofastack/sofa-boot#1323: Spring Boot version upgrade in `pom.xml`, related to dependency version management.
- sofastack/sofa-boot#1353: Spring Boot version bump in `pom.xml` and property, closely related in purpose.
## Suggested labels
`cla:yes`, `size/S`
## Suggested reviewers
- HzjNeverStop
- crazysaltfish
## Poem
> Hoppy news on the coding trail,
> Spring Boot now dons a fresh, new scale.
> My whiskers twitch in lines of code so neat,
> Leaping through versions with a joyful beat.
> I celebrate these changes with a merry hop—
> Here's to smooth builds that never stop!
> 🐇✨🚀Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: JermaineHua <[email protected]>
CrazyHZM
force-pushed
the
4.x_feat/ugrade_spring_boot_3.4.4
branch
from
1b43c97 to
6fdc5ad
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
sofa-boot-project/sofa-boot-actuator/src/main/java/com/alipay/sofa/boot/actuator/health/HealthIndicatorProcessor.java (1)
71-72: LGTM - Appropriate health indicator exclusion for Spring Boot 3.4.4The addition of
org.springframework.boot.actuate.ssl.SslHealthIndicatorto theDEFAULT_EXCLUDE_INDICATORSlist is correct and aligns with the Spring Boot version upgrade to 3.4.4. This new health indicator was introduced in Spring Boot 3.4.x and excluding it follows the same pattern as other similar health indicators likeLivenessStateHealthIndicatorandReadinessStateHealthIndicator.Consider adding a version comment to document when each indicator was added to the exclusion list to make future upgrades easier to track:
private static final List<String> DEFAULT_EXCLUDE_INDICATORS = Arrays .asList( "com.alipay.sofa.boot.actuator.health.NonReadinessCheck", "org.springframework.boot.actuate.availability.ReadinessStateHealthIndicator", - "org.springframework.boot.actuate.availability.LivenessStateHealthIndicator", - "org.springframework.boot.actuate.ssl.SslHealthIndicator"); + "org.springframework.boot.actuate.availability.LivenessStateHealthIndicator", // Spring Boot 3.x + "org.springframework.boot.actuate.ssl.SslHealthIndicator"); // Spring Boot 3.4.x
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pom.xml(2 hunks)sofa-boot-project/sofa-boot-actuator/src/main/java/com/alipay/sofa/boot/actuator/health/HealthIndicatorProcessor.java(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- pom.xml
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: stc
- GitHub Check: sca
Signed-off-by: JermaineHua <[email protected]>
Signed-off-by: JermaineHua <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1365 +/- ##
=========================================
Coverage 82.90% 82.90%
- Complexity 2970 2971 +1
=========================================
Files 340 340
Lines 9828 9828
Branches 1178 1178
=========================================
Hits 8148 8148
Misses 1164 1164
Partials 516 516 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit