Implement P10 cine file capability for cine reader #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y values to the full 12 bit range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the P10 cine file reading capabilities.
The current implementation within the reader for cine files does not properly handled 12 bit files compressed to packed 10 bit files. The reader properly unpacks them, but it does not apply the linearization lookup table necessary to go from 10 bit values to 12 bit.
I have added the lookup table to the utils folder and implement a function to implement it for the P10 images. I have also added an interpolation after this to adjust the black and white values of the image to span the full 12 bit range of the file.
I have not made a PR before so please let me know if I need to add anything more.