FIX: Zero cosmask at its center - #808
Open
sapunyangkut wants to merge 1 commit into
Open
Conversation
nkeim
approved these changes
Aug 13, 2026
nkeim
marked this pull request as ready for review
August 13, 2026 18:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cosmaskto zeroRoot cause
At the geometric center,
theta_maskevaluatesarctan2(0, 0)as zero. The previouscos(2 * theta)calculation therefore contributed1at the center, even though the eccentricity calculation expects that undefined angular contribution to be zero. For a center-only feature, this produced an eccentricity of1000000.0instead of0.0.Fixes #728.
Validation
Fresh publication checks on upstream commit
186fa02f048ef0902b6f9804874b701345a22398:1.0before the patch0.0after the patch and every non-center mask value is unchangedgit diff --checkpassedArchived test evidence from the same upstream commit, with its manifest reverified before publication:
reproducibility_v0.4.npzfixture retains 14 previous eccentricity valuesAutomation disclosure
This pull request was prepared and submitted by an OpenAI Codex agent operating on behalf of @sapunyangkut. The agent reproduced the bug, applied the minimal patch, verified the test evidence, and checked the repository's public contribution rules before submission.