feat: provide catch-all function to process dep rule#255
Closed
rainerhahnekamp wants to merge 5 commits into
Closed
feat: provide catch-all function to process dep rule#255rainerhahnekamp wants to merge 5 commits into
rainerhahnekamp wants to merge 5 commits into
Conversation
… param - Remove from/to from DependencyCheckContext; restore to intersection type - Add fromTags/toTags to DependencyCheckContext - Remove redundant tos param from isDependencyAllowed; use context.toTags - Drop dummy from/to values in checkForDependencyRuleViolation - Update tests to match new signatures Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credit goes to @sdurnov who did the original implementation in #246. Their commits are preserved as-is; a final fix commit addresses the review feedback.
Summary
fromTagsandtoTagstoDependencyCheckContextso matcher functions can inspect the full tag sets of both modulesRuleMatcherFnas an intersection type ({ from: string; to: string } & DependencyCheckContext) rather than flatteningfrom/tointo the context interfacetosparameter fromisDependencyAllowed— the function now iteratescontext.toTagsdirectly, eliminating duplicated data at every call siteTest plan
packages/core/src/lib/checks/tests/is-dependency-allowed.spec.ts— all 30 tests pass🤖 Generated with Claude Code