fix: address review feedback on catch-all dep rule (#246)#256
Merged
rainerhahnekamp merged 1 commit intoMay 31, 2026
Merged
Conversation
… param - Remove from/to from DependencyCheckContext; restore to intersection type - Add fromTags/toTags to DependencyCheckContext - Remove redundant tos param from isDependencyAllowed; use context.toTags - Drop dummy from/to values in checkForDependencyRuleViolation - Update tests to match new signatures Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #246 (authored by @sdurnov), which introduced
fromTags/toTagssupport in dependency rule matcher functions.This commit addresses the review feedback:
from/tofromDependencyCheckContext; restore them to theRuleMatcherFnintersection type as they were originallytosparameter fromisDependencyAllowed— the function now iteratescontext.toTagsdirectly, eliminating the duplicated data at every call sitefrom: ''/to: ''values that were needed incheckForDependencyRuleViolationas a result🤖 Generated with Claude Code