feat(CounterField): new component #335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaykKirakosyanSoft
requested review from
AregSoft,
GaroGabrielyan and
hamikhambardzumyan
as code owners
6 tasks
GaroGabrielyan
requested changes
Nov 10, 2025
Collaborator
GaroGabrielyan
left a comment
GaroGabrielyan
left a comment
There was a problem hiding this comment.
The CounterField component must accept decimal numbers and 'e'.
| // INPUT CONTAINER - Horizontal layout for buttons and text field | ||
| &__inputContainer { | ||
| display: flex; | ||
| align-items: center; |
Collaborator
There was a problem hiding this comment.
we don't need align-items: center; by default input and button has same height.
|
|
||
| // INPUT - Text field for manual value entry | ||
| &__input { | ||
| flex: 0 0 auto; |
Collaborator
There was a problem hiding this comment.
Why we need flex: 0 0 auto;?
| </div> | ||
|
|
||
| {helperText && ( | ||
| <div className="counterField__infoContainer"> |
Collaborator
There was a problem hiding this comment.
I think this is unnecessary wrapping.
Collaborator
Author
There was a problem hiding this comment.
Other components using helpertext do it exact same way.
…onents into feature/add-counter-field-component
…construct/gene-ui-components into feature/add-counter-field-component
…counter-field-component
…c digits also when controlled
…onents into feature/add-counter-field-component
…construct/gene-ui-components into feature/add-counter-field-component
…onents into feature/add-counter-field-component
…ovided with min\max
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic Build Summary
Build URL: https://www.chromatic.com/build?appId=66daee7859a843dd87bfb3d7&number=1059
Storybook URL: https://66daee7859a843dd87bfb3d7-uyjykdyzui.chromatic.com/