Support custom bind-mounts #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `TRYCI_BINDMOUNTS` environment variable, which can be used to mount arbitrary directories from the host to the docker container to be used in CI. A common pattern I find myself myself repeating is using `tryci` to run the full test suite on `yk` and repeating it a lot once I inevitably find my change has broken something. If my change includes an upstream change to `ykllvm` which hasn't landed yet, I can't take advantage of caching and have to wait almost an hour in-between builds. This hack lets me reduce my tryci builds back down to about 10 minutes by letting me bind-mount a pre-built `ykllvm` from my host machine. It has similar uses for other submodules like bdwgc in alloy.
|
Dumb question: should this be a flag to the tool or an environment variable? |
|
I made it an environment variable so I could add the bind-mounts to my local machine once in my |
|
I'm generally averse to environment variables, as they're so easy to get wrong. If we can flip it to a CLI switch, I think that would be much less prone to error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
TRYCI_BINDMOUNTSenvironment variable, which can be used to mount arbitrary directories from the host to the docker container to be used in CI.A common pattern I find myself myself repeating is using
trycito run the full test suite onykand repeating it a lot once I inevitably find my change has broken something.If my change includes an upstream change to
ykllvmwhich hasn't landed yet, I can't take advantage of caching and have to wait almost an hour in-between builds.This hack lets me reduce my tryci builds back down to about 10 minutes by letting me bind-mount a pre-built
ykllvmfrom my host machine. It has similar uses for other submodules like bdwgc in alloy.