-
Couldn't load subscription status.
- Fork 7
[DRIZZ-60] Default API Handler #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…i-new-default-handler
🦋 Changeset detectedLatest commit: 2e093a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Believe LGTM.
ฝาก TODO case one-to-one หน่อย น่าจะเจ๊งชัวร์ + จริงอยากให้ test ด้วยว่า ถ้า identifierColumn != pk มันจะยัง work มั้ย
กับฝาก TODO เรื่อง refactor test case หน่อย ที่จะไม่ใช่ท่า mock tx แต่ mock function ที่รับ tx แทน
Why I did
__pkand__idWhat I did