Skip to content

Conversation

@miello
Copy link
Contributor

@miello miello commented May 27, 2025

Why I did

  • Due to new api spec, default api handler and unit test need to be updated to follow the spec which including add __pk and __id
  • Currently, we cannot send PATCH request to update item in collection due to wrong route path defining

What I did

  • Revise default api handler to support new spec.
  • Fix problem that handler cannot use body from next js
  • Fix PATCH, DELETE request does not work as expected
  • Run typecheck to check if type error

@miello miello requested a review from saenyakorn May 27, 2025 09:13
@changeset-bot
Copy link

changeset-bot bot commented May 27, 2025

🦋 Changeset detected

Latest commit: 2e093a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@internals/project-config Minor
@example/erp Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@miello miello changed the base branch from main to yu/feat/auth-2 May 27, 2025 11:02
Base automatically changed from yu/feat/auth-2 to main May 27, 2025 12:34
Copy link
Member

@saenyakorn saenyakorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Believe LGTM.

ฝาก TODO case one-to-one หน่อย น่าจะเจ๊งชัวร์ + จริงอยากให้ test ด้วยว่า ถ้า identifierColumn != pk มันจะยัง work มั้ย

กับฝาก TODO เรื่อง refactor test case หน่อย ที่จะไม่ใช่ท่า mock tx แต่ mock function ที่รับ tx แทน

@miello miello requested a review from saenyakorn May 28, 2025 09:41
@miello miello merged commit 466827d into main May 28, 2025
1 check passed
@miello miello deleted the earth/feat/default-api-new-default-handler branch May 28, 2025 13:45
This was referenced Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants