Skip to content

feat: add action select #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 10, 2025
Merged

feat: add action select #164

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2132535
feat: add action select
t0ngk Aug 26, 2025
e88f0b7
Add changeset for action select feature
t0ngk Aug 26, 2025
e9e2a40
fix: click row still select
t0ngk Aug 26, 2025
d6c0d69
doc: add example for action select
t0ngk Aug 27, 2025
abd58bc
Merge commit '615d51ecc39ab29c88390aa823948fcae83c0f2b' into tong/fea…
t0ngk Aug 27, 2025
ac57ba6
Merge commit '615d51ecc39ab29c88390aa823948fcae83c0f2b' into tong/fea…
t0ngk Aug 27, 2025
20b800f
wip: action item helper
t0ngk Sep 3, 2025
ee7a7a7
Merge commit '2800037065ee2a067d4a48f65c7dc90d66dd396e' into tong/fea…
t0ngk Sep 3, 2025
076e9ba
feat: customize action items
t0ngk Sep 3, 2025
706a717
fix: remove unused hook and
jettapat-metier Sep 10, 2025
5aa9e5c
fix: remove context in props
jettapat-metier Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/spotty-chairs-tie.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@example/erp": patch
"@genseki/react": patch
---

feat: add action select
1 change: 1 addition & 0 deletions examples/erp/genseki/collections/tags.ts
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please provide an example for the select flag?

Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const list = builder.list(fields, {
search: ['name'],
sortBy: ['name'],
},
actions: { create: true, update: true },
})

const update = builder.update(fields, {})
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/core/collection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@
}): React.ReactElement
}
interface CustomCollectionUI<
TContext extends AnyContextable = AnyContextable,

Check warning on line 382 in packages/react/src/core/collection.ts

View workflow job for this annotation

GitHub Actions / ci 

'TContext' is defined but never used. Allowed unused vars must match /^_/u
TFields extends Fields = Fields,
> {
layout?: CustomCollectionLayout
Expand All @@ -404,6 +404,7 @@
update?: boolean
delete?: boolean
one?: boolean
select?: boolean
}
} & CollectionFieldsOptions<TContext, TFields>

Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/react/views/collections/list/list.client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export function ClientCollectionListView() {

const columnHelper = createColumnHelper<BaseData>()
return [
...(listViewProps.actions?.delete
...(listViewProps.actions?.select
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it mean delete will not be usable if select is not turned on.

Suggested change
...(listViewProps.actions?.select
...((listViewProps.actions?.select || listViewProps.actions?.delete)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no delete still useable in action dropdown this action is only for disable select action

? [
columnHelper.display({
id: 'select',
Expand Down Expand Up @@ -178,7 +178,7 @@ export function ClientCollectionListView() {
table={table}
loadingItems={pagination.pageSize}
className="static"
onRowClick="toggleSelect"
onRowClick={listViewProps.actions?.select ? 'toggleSelect' : undefined}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as previous comment

Suggested change
onRowClick={listViewProps.actions?.select ? 'toggleSelect' : undefined}
onRowClick={(listViewProps.actions?.select || listViewProps.actions?.delete) ? 'toggleSelect' : undefined}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as previous

isLoading={isLoading}
isError={isError}
configuration={listViewProps.listConfiguration}
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/react/views/collections/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ export interface ListActions {
update?: boolean
delete?: boolean
one?: boolean
select?: boolean
}
Loading