-
Couldn't load subscription status.
- Fork 7
[Fix] improve type and use collection form #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 775fc6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies type complexity by removing the overuse of the Simplify type utility and adds "use client" directive to the collection form hook for React client-side compatibility.
- Removes excessive
Simplifytype wrapping to reduce TypeScript compilation complexity - Adds "use client" directive to
useCollectionFormhook for Next.js client-side usage - Removes unused type definitions and imports to clean up the codebase
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| use-collection-form.ts | Adds "use client" directive for React client compatibility |
| utils.ts | Removes Simplify wrapper from return type |
| field.ts | Removes Simplify import and wrapper from return type |
| collection/index.tsx | Removes multiple Simplify wrappers and cleans up type definitions |
| builder.utils.ts | Removes unused CollectionDefaultAdminApiRouter type definition |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥳
Why did you create this PR
useCollectionFormWhat did you do
Screenshots / Recordings
Checklist