Skip to content

Conversation

@saenyakorn
Copy link
Member

Why did you create this PR

  • Wrong phone plugin login path
  • type utility RecordifyFlattenApiRouter does not infer correct type

What did you do

  • Fix phone plugin login path
  • Extract the actual value of RecordifyFlattenApiRouter instead of all union. For example

Before

type X = RecordifyFlattenApiRouter<typeof api> 
/*
* type X = {
*   "POST /some/path": ApiRoute<...> |  ApiRoute<...> | ApiRoute<...>
* }
**/

After

type X = RecordifyFlattenApiRouter<typeof api> 
/*
* type X = {
*   "POST /some/path": ApiRoute<...>
* }
**/

Screenshots / Recordings

Checklist

  • Self-reviewed your code
  • Wrote coverage tests
  • Added screenshots or recordings if applicable

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2025

🦋 Changeset detected

Latest commit: 3ffa0c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@genseki/plugins Patch
@genseki/react Patch
@example/erp Patch
@example/ui-playground Patch
@genseki/next Patch
@genseki/prisma-generator Patch
@genseki/react-query Patch
@genseki/rest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you enlighten me about what's changed in effect?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already in the PR's description

@saenyakorn saenyakorn merged commit 9b07b9c into main Sep 4, 2025
1 check passed
@saenyakorn saenyakorn deleted the yu/fix/recordify-type branch September 4, 2025 10:34
@github-actions github-actions bot mentioned this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants