Skip to content

Fix phone plugin bugs and simplify error code #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 8, 2025
Merged

Fix phone plugin bugs and simplify error code #181

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e66842f
fix: simplify error code and fix bugs
saenyakorn Sep 8, 2025
5d0e39c
fix: use token to find verification
saenyakorn Sep 8, 2025
d67c887
chore: add more error handling
saenyakorn Sep 8, 2025
83a5c51
Create pretty-spiders-build.md
saenyakorn Sep 8, 2025
43c81b0
chore: update cache
saenyakorn Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/pretty-spiders-build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@example/erp": patch
"@genseki/plugins": patch
---

Fix phone plugin bugs and simplify error code
10 changes: 10 additions & 0 deletions examples/erp/http.rest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,13 @@ Content-Type: application/json
"token": "4c6981ad-6fdf-47b2-b020-2b1b55aa1dc0",
"pin": "8"
}

###

POST http://localhost:3000/api/auth/phone/login
Content-Type: application/json

{
"phone": "0812345679",
"password": "password1"
}
25 changes: 11 additions & 14 deletions packages/plugins/src/phone/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ export function phone<
code: z.enum([
'FEATURE_NOT_ENABLED',
'USER_ALREADY_EXISTS',
'MAX_OTP_SEND_LIMIT_REACHED',
'REACHED_MAX_ATTEMPTS',
'FAILED_TO_SEND_OTP',
'FAILED_TO_CREATE_VERIFICATION',
'INTERNAL_SERVER_ERROR',
]),
message: z.string(),
}),
Expand Down Expand Up @@ -133,9 +133,10 @@ export function phone<
code: z.enum([
'INVALID_OR_EXPIRED_VERIFICATION_TOKEN',
'REACHED_MAX_ATTEMPTS',
'FAILED_OTP_VERIFICATION',
'FAILED_TO_VERIFY_OTP',
'ACCOUNT_NOT_FOUND',
'INTERNAL_SERVER_ERROR',
'FAILED_TO_CREATE_USER',
]),
message: z.string(),
}),
Expand Down Expand Up @@ -196,7 +197,7 @@ export function phone<
'FEATURE_NOT_ENABLED',
'REACHED_MAX_ATTEMPTS',
'FAILED_TO_SEND_OTP',
'FAILED_TO_CREATE_VERIFICATION',
'INTERNAL_SERVER_ERROR',
]),
message: z.string(),
}),
Expand Down Expand Up @@ -245,8 +246,8 @@ export function phone<
'INVALID_OR_EXPIRED_VERIFICATION_TOKEN',
'REACHED_MAX_ATTEMPTS',
'FAILED_TO_VERIFY_OTP',
'FAILED_TO_INCREASE_ATTEMPT',
'ACCOUNT_NOT_FOUND',
'INTERNAL_SERVER_ERROR',
]),
message: z.string(),
}),
Expand Down Expand Up @@ -289,12 +290,7 @@ export function phone<
message: z.string(),
}),
500: z.looseObject({
code: z.enum([
'INVALID_OR_EXPIRED_VERIFICATION_TOKEN',
'FAILED_TO_HASH_PASSWORD',
'FAILED_TO_UPDATE_PASSWORD',
'FAILED_TO_DELETE_VERIFICATION',
]),
code: z.enum(['INVALID_OR_EXPIRED_VERIFICATION_TOKEN', 'INTERNAL_SERVER_ERROR']),
message: z.string(),
}),
},
Expand Down Expand Up @@ -338,8 +334,8 @@ export function phone<
code: z.enum([
'FEATURE_NOT_ENABLED',
'USER_NOT_FOUND',
'PHONE_EXISTS',
'REACHED_MAX_OTP_SEND_LIMIT',
'PHONE_ALREADY_EXISTS',
'REACHED_MAX_ATTEMPTS',
'NEW_PHONE_AND_PHONE_IS_THE_SAME',
'CURRENT_PHONE_AND_OLD_PHONE_IS_NOT_THE_SAME',
'INTERNAL_SERVER_ERROR',
Expand Down Expand Up @@ -393,8 +389,9 @@ export function phone<
code: z.enum([
'FEATURE_NOT_ENABLED',
'INVALID_OR_EXPIRED_VERIFICATION_TOKEN',
'VERIFICATION_DOES_NOT_BELONGS_TO_USER',
'REACHED_MAX_ATTEMPTS',
'FAILED_OTP_VERIFICATION',
'FAILED_TO_VERIFY_OTP',
'INTERNAL_SERVER_ERROR',
]),
message: z.string(),
Expand Down
Loading
Loading