[DRIZZ-85,DRIZZ-86] withValidator and extra field problem

.changeset/blue-ghosts-rush.md

@@ -0,0 +1,6 @@
+---
+'@kivotos/core': patch
+---
+
+[[DRIZZ-86] Embed __pk to relation field](https://app.plane.so/softnetics/browse/DRIZZ-86/)
+[[DRIZZ-85] withValidator not working properly due to wrong response](https://app.plane.so/softnetics/browse/DRIZZ-85/)

packages/core/src/builder.handler.ts

@@ -7,7 +7,6 @@ import {
   Many,
   One,
   or,
-  sql,
   type TableRelationalConfig,
 } from 'drizzle-orm'
 import type { NodePgQueryResultHKT } from 'drizzle-orm/node-postgres'
@@ -42,33 +41,25 @@ export function createDefaultApiHandlers<
   schema: Record<string, unknown>
   fields: TFields
   tableTsKey: string
-  identiferColumn: string
+  identifierColumn: string
   tableNamesMap: Record<string, string>
   tables: Record<string, TableRelationalConfig>
 }): CollectionAdminApi<TContext, TFields> {
-  const { fields, tableTsKey, tableNamesMap, tables, schema, identiferColumn } = args
+  const { fields, tableTsKey, tableNamesMap, tables, schema, identifierColumn } = args
 
   const tableRelationalConfig = tables[tableTsKey]
   const primaryKeyColumn = getPrimaryColumn(tableRelationalConfig)
-  const identifierKeyColumn = tableRelationalConfig.columns[identiferColumn]
+  const identifierKeyColumn = tableRelationalConfig.columns[identifierColumn]
   const tableName = tableRelationalConfig.tsName
   const tableSchema = getTableFromSchema(schema, tableTsKey)
-  const queryPayload = createDrizzleQuery(fields)
-
-  const extrasQuery = {
-    extras: {
-      __pk: sql<string | number>`${primaryKeyColumn}`.as('__pk'),
-      __id: sql<string | number>`${identifierKeyColumn}`.as('__id'),
-    },
-  }
+  const queryPayload = createDrizzleQuery(fields, tables, tableRelationalConfig, identifierColumn)
 
   const findOne: ApiFindOneHandler<TContext, TFields> = async (args) => {
     const db = args.context.db
     const query = db.query[tableName as keyof typeof db.query] as RelationalQueryBuilder<any, any>
 
     const result = await query.findFirst({
       ...queryPayload,
-      ...extrasQuery,
       where: eq(primaryKeyColumn, args.id),
     })
     if (!result) {
@@ -94,7 +85,6 @@ export function createDefaultApiHandlers<
 
     const result = await query.findMany({
       ...queryPayload,
-      ...extrasQuery,
       limit: args.limit,
       offset: args.offset,
       orderBy: orderBy
@@ -136,7 +126,6 @@ export function createDefaultApiHandlers<
 
     const result = await query.findFirst({
       ...queryPayload,
-      ...extrasQuery,
       where: eq(primaryKeyColumn, pk),
     })
 
@@ -165,7 +154,6 @@ export function createDefaultApiHandlers<
       const pk = await apiHandler.update(args.id, tx, args.data)
       const result = await query.findFirst({
         ...queryPayload,
-        ...extrasQuery,
         where: eq(primaryKeyColumn, pk),
       })
 
@@ -574,19 +562,19 @@ function mapResultToFields(fields: Fields<any>, result: Record<string, any>): Re
         const value = result[field._.relationTsName]
         if (!value) return []
 
-        const primaryColumnTsName = field._.primaryColumnTsName
         if (Array.isArray(value)) {
           const values = value.map((v) => ({
             ...mapResultToFields(field.fields, v),
-            __pk: v[primaryColumnTsName],
+            __pk: v['__pk'],
+            __id: v['__id'],
           }))
           return [[field.fieldName, values]]
         }
 
         return [
           [
             field.fieldName,
-            { ...mapResultToFields(field.fields, value), __pk: value[primaryColumnTsName] },
+            { ...mapResultToFields(field.fields, value), __pk: value['__pk'], __id: value['__id'] },
           ],
         ]
       }

packages/core/src/builder.ts

@@ -82,7 +82,7 @@ export class Builder<
     const defaultHandlers = createDefaultApiHandlers({
       schema: this.config.schema,
       fields: config.fields,
-      identiferColumn: config.identifierColumn as string,
+      identifierColumn: config.identifierColumn as string,
       tableTsKey: tableTsName,
       tables: this.tableRelationalConfigByTableTsName,
       tableNamesMap: this.tableTsNameByTableDbName,

packages/core/src/utils.ts

@@ -1,7 +1,7 @@
-import type { Column, TableRelationalConfig } from 'drizzle-orm'
-import { is, Table } from 'drizzle-orm'
+import type { Column, SQL, TableRelationalConfig } from 'drizzle-orm'
+import { is, sql, Table } from 'drizzle-orm'
 import type { IsNever, Simplify, ValueOf } from 'type-fest'
-import type { ZodError, ZodObject, ZodOptional, ZodType } from 'zod'
+import type { ZodIssue, ZodObject, ZodOptional, ZodType } from 'zod'
 
 import type {
   ApiHttpStatus,
@@ -74,7 +74,28 @@ export function getTableFromSchema(schema: Record<string, unknown>, tableTsName:
   return schema[tableTsName]
 }
 
-export function createDrizzleQuery(fields: Fields<any>): Record<string, any> {
+const getExtraField = (tableRelational: TableRelationalConfig, identifierColumn?: string) => {
+  const extraWith: [string, SQL.Aliased<string | number>][] = []
+
+  const primaryKeyColumn = tableRelational.primaryKey[0]
+
+  extraWith.push(['__pk', sql`${primaryKeyColumn}`.as('__pk') as SQL.Aliased<string | number>])
+
+  if (identifierColumn) {
+    const identifierKeyColumn = tableRelational.columns[identifierColumn]
+
+    extraWith.push(['__id', sql`${identifierKeyColumn}`.as('__id') as SQL.Aliased<string | number>])
+  }
+
+  return Object.fromEntries(extraWith)
+}
+
+export function createDrizzleQuery(
+  fields: Fields<any>,
+  table: Record<string, TableRelationalConfig>,
+  tableRelationalConfig: TableRelationalConfig,
+  identifierColumn?: string
+): Record<string, any> {
   const queryColumns = Object.fromEntries(
     Object.values(fields).flatMap((field) => {
       if (field._.source !== 'column') return []
@@ -86,14 +107,18 @@ export function createDrizzleQuery(fields: Fields<any>): Record<string, any> {
     Object.values(fields).flatMap((field) => {
       if (!isRelationField(field)) return []
       const relationName = field._.relation.fieldName
+      const referencedTableName = field._.relation.referencedTableName
 
-      return [[relationName, createDrizzleQuery(field.fields) as any]]
+      return [
+        [relationName, createDrizzleQuery(field.fields, table, table[referencedTableName]) as any],
+      ]
     })
   )
 
   return {
     columns: queryColumns,
     with: queryWith,
+    extras: getExtraField(tableRelationalConfig, identifierColumn),
   }
 }
 
@@ -125,14 +150,16 @@ export async function validateRequestBody<
   TApiRouteSchema extends ApiRouteSchema = any,
   TContext extends Record<string, unknown> = Record<string, unknown>,
 >(schema: TApiRouteSchema, payload: ApiRouteHandlerPayloadWithContext<TApiRouteSchema, TContext>) {
-  let zodErrors: Partial<Record<'query' | 'pathParams' | 'headers' | 'body', ZodError>> | undefined
+  let zodErrors:
+    | Partial<Record<'query' | 'pathParams' | 'headers' | 'body', ZodIssue[]>>
+    | undefined
 
   if (schema.query) {
     const err = await schema.query.safeParseAsync((payload as any).query)
     if (!err.success) {
       zodErrors = {
         ...zodErrors,
-        query: err.error,
+        query: err.error.issues,
       }
     }
   }
@@ -142,7 +169,7 @@ export async function validateRequestBody<
     if (!err.success) {
       zodErrors = {
         ...zodErrors,
-        pathParams: err.error,
+        pathParams: err.error.issues,
       }
     }
   }
@@ -152,7 +179,7 @@ export async function validateRequestBody<
     if (!err.success) {
       zodErrors = {
         ...zodErrors,
-        headers: err.error,
+        headers: err.error.issues,
       }
     }
   }
@@ -162,7 +189,7 @@ export async function validateRequestBody<
     if (!err.success) {
       zodErrors = {
         ...zodErrors,
-        body: err.error,
+        body: err.error.issues,
       }
     }
   }
@@ -217,7 +244,7 @@ export function withValidator<
         status: 500,
         body: {
           error: 'Response validation failed',
-          details: validationError,
+          details: validationError.issues,
         },
       }
     }