Skip to content

Conversation

@SupakornNetsuwan
Copy link
Collaborator

@SupakornNetsuwan SupakornNetsuwan commented Oct 13, 2025

Why did you create this PR

What did you do

  • Migrate from tv to cva
  • Introducing create-required-context
  • Incremental adopting Intent UI color system to Shadcn color system from
  • Rename and deprecated react aria
    • textfield
    • label
    • button
    • popover (with children composible components too)
    • dialog (with children composible components too)
    • modal (with children composible components too)
    • sheet (with children composible components too)
    • base-icon
    • combobox (with children composible components too)
    • field-group
  • Migrate textfield to Shadcn (Not completely 100% from entirely project perspective, since some compound component required react aria primitive component as a base, the change will incrementally adopt)
  • Migrate button to Shadcn (Not completely 100% from entirely project perspective, since some compound component required react aria primitive component as a base, the change will incrementally adopt)
  • Create Shadcn UI playground for Shadcn particularly
  • Change UI playground project structure
  • Introducing to new components by Shadcn
    • Input
    • Input group
    • Button
    • Label
    • Dialog
    • Menu
    • Popover
    • Combobox composition
    • Command (from cmdk)

Screenshots / Recordings

Button & Button group

CleanShot 2568-10-14 at 10 59 22 CleanShot 2568-10-14 at 15 44 37

Combobox

CleanShot.2568-10-14.at.11.31.21.mp4

Input & Input group

CleanShot 2568-10-14 at 11 33 47 CleanShot 2568-10-14 at 11 33 58 CleanShot 2568-10-14 at 11 34 13 CleanShot 2568-10-14 at 11 34 25 CleanShot 2568-10-14 at 11 34 35 CleanShot 2568-10-14 at 11 34 45

Autofield

CleanShot 2568-10-14 at 11 35 05

Some part of Autofield component has been moved to Shadcn UI from Intent UI, this introduce to e.g. Input, Textfield, Label, but the migration of Autofield hasn't been completely moved since some of compound react aria components are coupling with primitive react aria component e.g. comobox, selectbox, radio group. thus the component may partially migrated e.g. change only label part, changing only button part. The full migration of each compound components will be done when it's time for that component

Checklist

  • Self-reviewed your code
  • Wrote coverage tests
  • Added screenshots or recordings if applicable

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2025

🦋 Changeset detected

Latest commit: a79b0e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@example/ui-playground Patch
@genseki/react Patch
@example/erp Patch
@genseki/next Patch
@genseki/plugins Patch
@genseki/prisma-generator Patch
@genseki/react-query Patch
@genseki/rest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SupakornNetsuwan SupakornNetsuwan changed the title [DRAFT][migrate] textfield, button, label, dialog, sheet and more [DRAFT] Migrate: textfield, button, label, dialog, sheet and more Oct 13, 2025
@SupakornNetsuwan SupakornNetsuwan marked this pull request as ready for review October 14, 2025 04:57
@SupakornNetsuwan SupakornNetsuwan changed the title [DRAFT] Migrate: textfield, button, label, dialog, sheet and more Migrate: textfield, button, label, dialog, sheet and more Oct 14, 2025
@saenyakorn
Copy link
Member

Great work! Here's what I want you to fix. Other than that LGTM

  1. A11y for ComboBox. According to w3.org https://www.w3.org/WAI/ARIA/apg/patterns/combobox/, "Down Arrow" should show options
CleanShot.2568-10-14.at.12.26.13.mp4
  1. File upload preview (to be discuss with Designer). You may need "InputPeview" component for displaying a preview. Will de discuss later
CleanShot 2568-10-14 at 12 28 12@2x

@saenyakorn
Copy link
Member

One more things I would like from this PR is button group. I would be great if you implement it

@saenyakorn
Copy link
Member

Last one, add changeset to describe the change and scope of this PR

@SupakornNetsuwan
Copy link
Collaborator Author

  • Migrateseparator to Shadcn
  • Fix combobox A11y key and border outline
  • Add new button-group
  • Remove button-link and move to asChild button implementation instead
  • Imrpove create-required-context function

@SupakornNetsuwan SupakornNetsuwan merged commit 037e2f1 into main Oct 14, 2025
1 check passed
@SupakornNetsuwan SupakornNetsuwan deleted the supakorn/migrate/components branch October 14, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants