Skip to content

Conversation

@miello
Copy link
Contributor

@miello miello commented May 31, 2025

Why I did

  • Due to tables mapped from tsName but we use tableName, it causes error when tableName does not match to tsName as it causes error in testcase

What I did

  • Fix expected result in testcase and lookup tableRelationalConfig logic

@miello miello requested a review from saenyakorn May 31, 2025 05:05
@changeset-bot
Copy link

changeset-bot bot commented May 31, 2025

🦋 Changeset detected

Latest commit: a0ec276

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -0,0 +1,5 @@
---
'@example/erp': patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changeset กับ real change ไม่ match

@miello miello merged commit ebc7cc9 into main Jun 5, 2025
1 check passed
@miello miello deleted the miello/fix/unmatch-db-and-column-name branch June 5, 2025 09:29
This was referenced Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants