-
Couldn't load subscription status.
- Fork 7
feat: multi-select, tag-group
#29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SupakornNetsuwan
commented
Jun 4, 2025
🦋 Changeset detectedLatest commit: d02a6d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds and showcases new UI components (MultipleSelect, TagGroup, Badge updates) and introduces a utility (VisuallyHidden) in the playground.
- Introduce
MultipleSelectandTagGroupcomponents with examples inui-playground - Add
VisuallyHiddenutility and its dependency - Refactor
Badgespacing/size, renameCaretDowntoCaretDownIcon, and mark required fields inSelect
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/next/src/pages/ui-playground.tsx | Add playground demos for MultipleSelect, TagGroup, and Badge |
| packages/next/src/intentui/ui/visually-hidden.tsx | New VisuallyHidden component |
| packages/next/src/intentui/ui/tag-group.tsx | New TagGroup, TagList, and Tag components |
| packages/next/src/intentui/ui/multiple-select.tsx | New MultipleSelect and related items |
| packages/next/src/intentui/ui/select.tsx | Rename CaretDown to CaretDownIcon, add required indicator |
| packages/next/src/intentui/ui/badge.tsx | Update badgeShapes spacing and badgeStyles text size |
| packages/next/package.json | Add @react-aria/visually-hidden dependency |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (3)
packages/next/src/intentui/ui/tag-group.tsx:3
- The hook 'use' is not valid for accessing React context. Replace it with 'useContext' and import 'useContext' from 'react'.
import { createContext, use } from 'react'
packages/next/src/intentui/ui/multiple-select.tsx:204
- The Tailwind class 'min-w-(--trigger-width)' is invalid syntax. Use bracket notation like 'min-w-[--trigger-width]' to reference a CSS variable.
className="min-w-(--trigger-width) overflow-hidden"
packages/next/src/intentui/ui/multiple-select.tsx:211
- Tailwind does not support 'shadow-0'; use 'shadow-none' to remove box shadow.
className="max-h-[inherit] min-w-[inherit] border-0 shadow-0"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ฝากเพิ่ม changeset
c57f29c to
aa58557
Compare