Skip to content

fix: tabs component styling unknown reason reverted back to old one. #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SupakornNetsuwan merged 2 commits into from
Dec 1, 2025
Merged

fix: tabs component styling unknown reason reverted back to old one. #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2323926
fix: `tabs` component styling unknown reason reverted back to old one.
SupakornNetsuwan Dec 1, 2025
b45ea3f
chore: add changeset.
SupakornNetsuwan Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-flowers-type.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@genseki/ui": patch
---

fix: `tabs` component styling unknown reason reverted back to old one.
10 changes: 6 additions & 4 deletions packages/ui/src/components/primitives/tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ import { cn } from '../../utils/cn'
type Variants = 'default' | 'underline'

const tabListVariants = cva<{ variant: Record<Variants, any> }>(
'h-18 w-fit items-center justify-center',
'w-full items-center justify-center',
{
variants: {
variant: {
default: 'bg-muted text-muted-foreground inline-flex rounded-lg p-[3px]',
underline: '',
underline: 'border-b',
},
},
defaultVariants: {
Expand All @@ -32,8 +32,10 @@ const tabVariants = cva<{ variant: Record<Variants, any> }>(
variant: {
default:
'h-[calc(100%-1px)] gap-3 data-[state=active]:bg-background dark:data-[state=active]:text-foreground focus-visible:ring-ring dark:data-[state=active]:border-input dark:data-[state=active]:bg-input/30 text-foreground dark:text-muted-foreground rounded-md border border-transparent px-4 py-2 focus-visible:ring-[2px] data-[state=active]:shadow-sm ',
underline:
'data-[state=active]:text-primary data-[state=active]:border-primary px-3 pb-5 border-b-[2px] focus-visible:ring-[2px] focus-visible:ring-ring focus-visible:ring-offset-2',
underline: [
'relative data-[state=active]:text-primary px-3 pb-5 focus-visible:ring-[2px] focus-visible:ring-ring focus-visible:ring-offset-2',
'before:absolute before:block before:content-[""] data-[state=active]:before:w-full before:h-1 before:bg-primary before:-bottom-px',
],
},
},
defaultVariants: {
Expand Down
Loading