Skip to content

fix: separator overriding. #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SupakornNetsuwan merged 1 commit into from
Dec 2, 2025
Merged

fix: separator overriding. #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/bold-webs-read.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@example/ui-playground': patch
'@genseki/ui': patch
---

fix: separator class overriding.
5 changes: 4 additions & 1 deletion examples/ui-playground/src/app/playground/shadcn/separator-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ function BasicSeparatorExamples() {
</div>
<div className="flex h-24 items-center gap-4">
<span className="text-sm text-muted-foreground">Top</span>
<Separator orientation="vertical" className="h-full" />
<Separator
orientation="vertical"
className="bg-blue-500 data-[orientation=vertical]:w-4"
/>
<span className="text-sm text-muted-foreground">Bottom</span>
</div>
<div className="flex items-center gap-4">
Expand Down
4 changes: 3 additions & 1 deletion packages/ui/src/components/primitives/separator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import React from 'react'
import * as SeparatorPrimitive from '@radix-ui/react-separator'
import { cva, type VariantProps } from 'class-variance-authority'

import { cn } from '../../utils/cn'

/**
* Shadcn component
*/
Expand Down Expand Up @@ -39,7 +41,7 @@ function Separator({
data-slot="separator"
decorative={decorative}
orientation={orientation}
className={separator({ variant, className })}
className={cn(separator({ variant }), className)}
{...props}
/>
)
Expand Down
Loading