Skip to content

feat: add classname props for filter #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeerapatChan merged 2 commits into from
Mar 26, 2026
Merged

feat: add classname props for filter #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f08c6e3
feat: add classname props for filter
TeerapatChan Mar 26, 2026
028ec11
Create lovely-owls-rest.md
TeerapatChan Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lovely-owls-rest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@genseki/ui": patch
---

feat: add classname props for filter
15 changes: 12 additions & 3 deletions packages/ui/src/components/primitives/filter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,13 @@ export function getSelectedValues<T extends string>(options: FilterOption<T>[])
export interface FilterProps<T extends FilterOptions = FilterOptions> {
options: T
onChange: (options: T) => void
classNames?: {
trigger?: string
content?: string
}
}

export function Filter<T extends FilterOptions>({ options, onChange }: FilterProps<T>) {
export function Filter<T extends FilterOptions>({ options, onChange, classNames }: FilterProps<T>) {
const [openModal, setOpenModal] = React.useState(false)
const [internalOptions, setInternalOptions] = React.useState<T>(options)
const [selectedColumn, setSelectedColumn] = React.useState<string | null>(
Expand Down Expand Up @@ -82,14 +86,19 @@ export function Filter<T extends FilterOptions>({ options, onChange }: FilterPro
return (
<Popover open={openModal} onOpenChange={setOpenModal}>
<PopoverTrigger asChild>
<Button variant="outline" className="w-fit">
<Button variant="outline" className={cn('w-fit', classNames?.trigger)}>
<Typography className="text-icon-tertiary">Filter</Typography>
<CountBadge count={totalSelected} />
<SlidersHorizontalIcon className="text-icon-tertiary" />
</Button>
</PopoverTrigger>
<PopoverContent asChild>
<div className="w-fit py-6 bg-surface-primary border border-border-primary rounded-xl flex flex-col gap-4 min-w-[600px] h-[436px]">
<div
className={cn(
'w-fit py-6 bg-surface-primary border border-border-primary rounded-xl flex flex-col gap-4 min-w-[600px] h-[436px]',
classNames?.content
)}
>
<Typography type="h4" weight="bold" className="px-6 text-lg w-full">
Apply Filters
</Typography>
Expand Down
Loading