Switch from winapi to windows-sys #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
approved these changes
Jun 11, 2022
3 tasks
|
Howdy! Just came across this, anything else needed to get this across the finish line? (@arlosi Could use an update to 0.42 if you still have cycles.) |
|
Updated to 0.42. I don't know of anything else necessary other than approval from @softprops. Before it has any impact, we'll also need a version bump and it to be published to crates.io. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
winapicrate has not been updated in two years. The replacement iswindows-sys.Testing: compiled with old
rustc(1.39.0)Build performance: compilation time improved from
4.2 secto3.1 sec.