feat: enhance boolean parsing for environment variables #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelhe
force-pushed
the
improve-boolean
branch
4 times, most recently
from
29801d8 to
c453db1
Compare
Add support for common boolean representations in environment variables beyond the standard Rust bool parsing. Now accepts various forms like: - True values: "y", "yes", "t", "true", "on", "1" - False values: "n", "no", "f", "false", "off", "0", "" This makes the library more user-friendly and aligns with common expectations for environment variable configuration. Implementation draws inspiration from clap_builder and python-humanfriendly. Signed-off-by: Michel Heily <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for common boolean representations in environment variables beyond the standard Rust bool parsing. Now accepts various forms like:
This makes the library more user-friendly and aligns with common expectations for environment variable configuration. Implementation draws inspiration from clap_builder and python-humanfriendly.
What did you implement:
Closes: #xxx
How did you verify your change:
Added tests for both success and error cases
What (if anything) would need to be called out in the CHANGELOG for the next release:
Add support for common boolean representations in environment variables beyond the standard Rust bool parsing. Now accepts various forms like: