forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix reload issues related to new SignInPage
#238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mateuuszzzzz
wants to merge
5,355
commits into
bring-back-new-sign-in-page
from
fix-reload-on-new-sign-in-page
Closed
Fix reload issues related to new SignInPage
#238
mateuuszzzzz
wants to merge
5,355
commits into
bring-back-new-sign-in-page
from
fix-reload-on-new-sign-in-page
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
war-in
reviewed
Jun 30, 2025
.../hybrid-app/android/src/main/java/com/expensify/reactnativehybridapp/ReactNativeHybridApp.kt
Outdated
Show resolved
Hide resolved
…stToAPI [Merge on Friday pls] Switch to API method for checklist generation
…mistic-gbr Display GBR when create empty report
…issue Expense - Report preview shows loader when created offline and still shows loader when online
…ted-modals Fix Help Panel freezing the app when opened from a modal
Fix/65341 - Emoji picker aligns to top when navigating with keyboard open
…prove-lottie-display-logic Perf: Unmount Lottie animation when invisible to avoid a leak
…PersonalDeatilsUtils Revert "[Part 2]: Remove usage of Onyx.connect for ONYXKEYS.COUNTRY_CODE"
Fix: User is navigated to the other report the expense was moved to
fix: copilot with limited access is able to pay IOU via QAB
…-usd-6th-step feat: Add 6th step to USD reimbursement account flow
…-wording-update BBA Add bank account wording update
[CP Staging] Revert Expensify#65081
Generate thread if needed
Search: Add total spend footer (2)
…rt-transaction-v3
…2/missing-currency-in-settlement-button
…idOptions-includeCurrentUser [CP Staging] Fix: Add missing includeCurrentUser in getValidOptions usages
…7-postTestCoverage
fix: chat - infinite loading spinner after split expense
Add z-index 10000 to splash screen to prevent third-party overlay issues
…2/missing-currency-in-settlement-button
…-currency-in-settlement-button Expense - Pay with Expense button is shown in main chat and absent in expense report
feat: implement distance rate name edit page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop