Fix the keyboard issue in the SignInModal along with derivatives - #243
Closed
OlGierd03 wants to merge 916 commits into
Closed
Fix the keyboard issue in the SignInModal along with derivatives#243OlGierd03 wants to merge 916 commits into
OlGierd03 wants to merge 916 commits into
Conversation
zfurtak
approved these changes
Aug 21, 2025
zfurtak
left a comment
Member
There was a problem hiding this comment.
The code looks solid, great job 🚀
Please make sure it passes all the tests and don’t forget to add the related issue link to the description 😃
Author
|
Thanks for the review and the reminder to link the related issue! Since this PR is going to the fetch branch that's missing some flows, the tests won't pass yet. They'll be good to go once we want to merge the main PR with all the functionality 🚀 |
|
Thanks for picking this up @OlGierd03, I made a specific issue here for tracking the bug. |
49 tasks
Revert Expensify#68402 "[Manual distance] Create the distance creation tabs"
* main: (180 commits) Update Mobile-Expensify submodule version to 9.1.99-1 Update version to 9.1.99-1 Revert "Merge pull request Expensify#68402 from dominictb/feat/64849" Update Central-Billing.md Rename central-billing.md to Central-Billing.md Revert "fix: `ActionSheetAwareScrollView` not working with `maintainVisibleContentPosition`" fix: Unable to delete message in chat on Android renamed function Update Mobile-Expensify submodule version to 9.1.99-0 Update version to 9.1.99-0 fix: unknow user is displayed if selecting another report Update Mobile-Expensify submodule version to 9.1.98-12 Update version to 9.1.98-12 fix: hovering over the new user avatar does not display email Update src/components/Modal/ReanimatedModal/Container/index.tsx eslint-rule remove empty line add UTs Update central-billing.md Update Mobile-Expensify submodule version to 9.1.98-11 ...
Fix Android sign-in flow preventing multiple signInToOldDot calls
…tch-4 Create Event-Management
* main: Update Travel-Event-Management.md Update Booking-Event-Travel.md remove duplicate page fix remaining route issue Create Booking-Event-Travel.md Create Booking-Travel-for-Event-Attendees.md Create View-Event-As-Employee-or-Guest.md Create Booking-Travel-for-Event-Attendees.md move page to correct dir remove redirect create subcategory Rename Event-Management to Event-Management.md Rename docs/articles/travel/Event-Management to docs/articles/travel/hubs/Event-Management Update redirects.csv Create Event-Management
…sionAgain [NO QA] Correct the main branch versioning
…tion_column Render description as text in the reports page
Modify CODEOWNERS for PR review assignments
…ove-back-to-from-expense-report-v2 Remove `backTo` from `ROUTES.SEARCH_MONEY_REQUEST_REPORT` v2
…-invoice-is-blurred Invoice - created invoice report is blurred when offline
…id/bump-react-native-live-markdown-to-0.1.302 Bump live-markdown to 0.1.302
…approver Fix empty default approver
…ensify-wordmark-color-on-ios Fix Expensify word mark fill on iOS
…is-revert-68429 [NoQA] Integrate Group-IB FP module
Fix/68418 - "Uncaught SyntaxError" console error when navigating to the "Free Features In Expensify" help page
…Autocomplete Update CSP to allow Google autocomplete requests
…walID Create withdrawal id filter
[Manual distance] Create the distance creation tabs v2
…patch-5 [NO QA] Removing extra period
Inconsistent animation direction when navigating back from QuickBooksDesktop flow
…/68395 fix: Tags setting - Members must tag all expenses toggle is misaligned in some languages.
…load-heic-to Lazy load HEIC conversion library on web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
In the SignInModal on android app, when the keyboard appears, the view shifts and the footer extends, blocking part of the view.
Fixed Issues
$ Expensify#69068
$ Expensify#67863
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Recording_20250820_164004.2.mp4
Android: mWeb Chrome
Screen.Recording.2025-08-20.at.16.04.50.mp4
iOS: Native
ScreenRecording_08-20-2025.16-19-44_1.mp4
iOS: mWeb Safari
Screen.Recording.2025-08-20.at.16.00.41.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-08-20.at.15.52.42.mp4
MacOS: Desktop
Screen.Recording.2025-08-20.at.16.52.54.mp4