Skip to content

Fix the keyboard issue in the SignInModal along with derivatives - #243

Closed
OlGierd03 wants to merge 916 commits into
migrate-hybrid-app-to-new-dot-sign-in-pagefrom
@OlGierd03/fix-reload-on-new-sign-in-page
Closed

Fix the keyboard issue in the SignInModal along with derivatives#243
OlGierd03 wants to merge 916 commits into
migrate-hybrid-app-to-new-dot-sign-in-pagefrom
@OlGierd03/fix-reload-on-new-sign-in-page

Conversation

@OlGierd03

@OlGierd03 OlGierd03 commented Aug 20, 2025

Copy link
Copy Markdown

Explanation of Change

In the SignInModal on android app, when the keyboard appears, the view shifts and the footer extends, blocking part of the view.

Fixed Issues

$ Expensify#69068
$ Expensify#67863

Tests

  1. Make sure to be logged out of your account.
  2. Open public room page via deep link (e.g. https://staging.new.expensify.com/r/5583419180793784).
  3. Click Join or Sign in button.
  4. Click on the input window to display the keyboard and verify that footer hasn't expanded, blocking much of the view.

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Recording_20250820_164004.2.mp4
Android: mWeb Chrome
Screen.Recording.2025-08-20.at.16.04.50.mp4
iOS: Native
ScreenRecording_08-20-2025.16-19-44_1.mp4
iOS: mWeb Safari
Screen.Recording.2025-08-20.at.16.00.41.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-08-20.at.15.52.42.mp4
MacOS: Desktop
Screen.Recording.2025-08-20.at.16.52.54.mp4

@zfurtak zfurtak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks solid, great job 🚀
Please make sure it passes all the tests and don’t forget to add the related issue link to the description 😃

@OlGierd03 OlGierd03 self-assigned this Aug 22, 2025
@OlGierd03

OlGierd03 commented Aug 22, 2025

Copy link
Copy Markdown
Author

Thanks for the review and the reminder to link the related issue! Since this PR is going to the fetch branch that's missing some flows, the tests won't pass yet. They'll be good to go once we want to merge the main PR with all the functionality 🚀

@Julesssss

Julesssss commented Aug 22, 2025

Copy link
Copy Markdown

Thanks for picking this up @OlGierd03, I made a specific issue here for tracking the bug.

luacmartins and others added 24 commits August 26, 2025 14:55
Revert Expensify#68402 "[Manual distance] Create the distance creation tabs"
* main: (180 commits)
  Update Mobile-Expensify submodule version to 9.1.99-1
  Update version to 9.1.99-1
  Revert "Merge pull request Expensify#68402 from dominictb/feat/64849"
  Update Central-Billing.md
  Rename central-billing.md to Central-Billing.md
  Revert "fix: `ActionSheetAwareScrollView` not working with `maintainVisibleContentPosition`"
  fix: Unable to delete message in chat on Android
  renamed function
  Update Mobile-Expensify submodule version to 9.1.99-0
  Update version to 9.1.99-0
  fix: unknow user is displayed if selecting another report
  Update Mobile-Expensify submodule version to 9.1.98-12
  Update version to 9.1.98-12
  fix: hovering over the new user avatar does not display email
  Update src/components/Modal/ReanimatedModal/Container/index.tsx
  eslint-rule
  remove empty line
  add UTs
  Update central-billing.md
  Update Mobile-Expensify submodule version to 9.1.98-11
  ...
Fix Android sign-in flow preventing multiple signInToOldDot calls
* main:
  Update Travel-Event-Management.md
  Update Booking-Event-Travel.md
  remove duplicate page
  fix remaining route issue
  Create Booking-Event-Travel.md
  Create Booking-Travel-for-Event-Attendees.md
  Create View-Event-As-Employee-or-Guest.md
  Create Booking-Travel-for-Event-Attendees.md
  move page to correct dir
  remove redirect
  create subcategory
  Rename Event-Management to Event-Management.md
  Rename docs/articles/travel/Event-Management to docs/articles/travel/hubs/Event-Management
  Update redirects.csv
  Create Event-Management
youssef-lr and others added 29 commits August 28, 2025 19:27
…sionAgain

[NO QA] Correct the main branch versioning
…tion_column

Render description as text in the reports page
Modify CODEOWNERS for PR review assignments
…ove-back-to-from-expense-report-v2

Remove `backTo` from `ROUTES.SEARCH_MONEY_REQUEST_REPORT` v2
…-invoice-is-blurred

Invoice - created invoice report is blurred when offline
…id/bump-react-native-live-markdown-to-0.1.302

Bump live-markdown to 0.1.302
…ensify-wordmark-color-on-ios

Fix Expensify word mark fill on iOS
…is-revert-68429

[NoQA] Integrate Group-IB FP module
Fix/68418 - "Uncaught SyntaxError" console error when navigating to the "Free Features In Expensify" help page
…Autocomplete

Update CSP to allow Google autocomplete requests
[Manual distance] Create the distance creation tabs v2
Inconsistent animation direction when navigating back from QuickBooksDesktop flow
…/68395

fix: Tags setting - Members must tag all expenses toggle is misaligned in some languages.
…load-heic-to

Lazy load HEIC conversion library on web
@zfurtak zfurtak closed this Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.