War in/domains/add vacation delegate page by war-in · Pull Request #283 · software-mansion-labs/expensify-app-fork

war-in · 2026-01-13T10:47:34Z

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

war-in · 2026-01-16T14:39:40Z

+ *
+ * @param accountID - The account ID of the domain member.
+ */
+function vacationDelegateSelector(accountID:number): (domain: OnyxEntry<Domain>) => BaseVacationDelegate | undefined {


we probably need tests for that one

war-in · 2026-01-16T15:06:17Z

this diff is not relevant (probably some unused imports)
let's fix eslint and prettier

…n all expenses are selected"

…k/migrate-AddDelegatePage Make `AddDelegatePage` use new `SelectionListWithSections`

…k/migrate-CategoryPicker Make `CategoryPicker` use new `SelectionListWithSections`

…mberMapping for clarity Updated the naming convention in the useCompanyCards hook and related components to improve clarity. The variable cardNamesToEncryptedCardNumber has been renamed to cardNamesToEncryptedCardNumberMapping across the codebase, including tests, to better reflect its purpose. This change enhances code readability and consistency.

…acking-settings-page Create Time Tracking settings page

…ng-personal-cards

…teDescription Refactor: isolate updateDescription from Onyx.connect ONYXKEYS.COLLECTION.REPORT

…l-expenses-select-actions-money-report-header Revert "Show Submit/Approve/Pay actions for selected transactions when all expenses are selected"

…veFromRoom Refactor: isolate removeFromRoom from Onyx.connect ONYXKEYS.COLLECTION.REPORT

…owRunLink [No QA] Include link to workflow run in PolyglotParrot comments

…n-adminroom [NoQA] Show the AZ status indicator in the admin room

…nslation [CP Staging] Fix translating `you`

fix: company card - 3 Dot menu is still clickable in offline mode

[Sprint] Release 3.3 - Deleting Personal Card Feed

…p-platform-OS-select-from-the-Hermes-bundle Revert "Cleanup platform specifics from hermes build"

Fix/74569 - Deleting IOU's in bulk shows empty report briefly

…ncierge-follow-ups-release-3-pregenerated-responses [Suggested Follow-ups][R3] Implement instant reply + optimistic reconciliation

[NoQA] Version bump to v9.3.11-14

fix: Refetch expanded group data on toggle to prevent stale transactions after date edits

…1-Top-Categories-Add-group-by-category fix: regression fixes for Top Categories (Expensify#80668, Expensify#80709)

…1-Top-Categories-Add-a-limit-filter-to-search fix: [Insights] Prevent empty limit from polluting query and add description to Limit filter

fix: Imported contacts do not appear in the contact list

# Conflicts: # src/ROUTES.ts # src/languages/en.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx # src/libs/Navigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts # src/libs/Navigation/linkingConfig/config.ts # src/libs/Navigation/types.ts # src/libs/actions/Domain.ts # src/selectors/Domain.ts # src/types/onyx/DomainErrors.ts # tests/unit/DomainSelectorsTest.ts

sumo-slonik reviewed Jan 13, 2026

View reviewed changes

Comment thread src/components/BaseVacationDelegateSelectionComponent.tsx Outdated

war-in commented Jan 16, 2026

View reviewed changes

sumo-slonik force-pushed the war-in/domains/add-vacation-delegate-page branch 2 times, most recently from ef60fb0 to 10abb4b Compare January 20, 2026 10:17

situchan and others added 26 commits January 29, 2026 20:52

Revert "Show Submit/Approve/Pay actions for selected transactions whe…

8b5b228

…n all expenses are selected"

Merge branch 'main' into time-tracking-settings-page

aec6e76

use Object.hasOwn instead of lodashHas

5395d2f

Fix offline indicator jumping on dismiss keyboard on mweb safari

3c02538

optimize isScanning function

8ba5b69

Merge branch 'Expensify:main' into 79160

6bff871

Merge remote-tracking branch 'origin/main' into dew-approve-support

b96121f

feedback

7fb3472

Minor refactor in getReasonAndReportActionThatRequiresAttention

4047a6a

fixing ts

231b574

Reuse quarter date helper

4d6f936

Fix app crashing when sharing videos on iOS

9f855b0

Merge pull request Expensify#80484 from software-mansion-labs/@zfurta…

bf0d596

…k/migrate-AddDelegatePage Make `AddDelegatePage` use new `SelectionListWithSections`

Merge pull request Expensify#80623 from software-mansion-labs/@zfurta…

7285520

…k/migrate-CategoryPicker Make `CategoryPicker` use new `SelectionListWithSections`

fix route nav

89ed8ef

declare empty set outside of useOnyx

eceb413

Merge branch 'main' into fix-company-cards-skeleton

b639387

Merge pull request Expensify#80331 from software-mansion-labs/time-tr…

e2ff5f7

…acking-settings-page Create Time Tracking settings page

Rely on labels height when adding extra height

02a55c8

Fix font path to use alias

eabf74f

Merge remote-tracking branch 'upstream/main' into feat/waterim/existi…

23f8ecb

…ng-personal-cards

update translation

010bdb7

Merge pull request Expensify#80336 from shubham1206agra/refactor-upda…

76c2782

…teDescription Refactor: isolate updateDescription from Onyx.connect ONYXKEYS.COLLECTION.REPORT

Merge pull request Expensify#80871 from situchan/revert-78426-feat/al…

01311a2

…l-expenses-select-actions-money-report-header Revert "Show Submit/Approve/Pay actions for selected transactions when all expenses are selected"

Merge pull request Expensify#80595 from shubham1206agra/refactor-remo…

96995cd

…veFromRoom Refactor: isolate removeFromRoom from Onyx.connect ONYXKEYS.COLLECTION.REPORT

rlinoz and others added 29 commits January 29, 2026 18:01

remove space

6d75239

Include link to workflow run in polyglot parrot comments

26a7b7d

Merge pull request Expensify#80981 from Expensify/Rory-PolyglotWorkfl…

3541394

…owRunLink [No QA] Include link to workflow run in PolyglotParrot comments

fix some AI comments

615e610

Merge pull request Expensify#80947 from Expensify/mollfpr-az-status-o…

e80f66b

…n-adminroom [NoQA] Show the AZ status indicator in the admin room

Merge pull request Expensify#80973 from Expensify/rodrigo-fix-you-tra…

ece75f4

…nslation [CP Staging] Fix translating `you`

Merge pull request Expensify#80439 from NJ-2020/fix/79443

3142888

fix: company card - 3 Dot menu is still clickable in offline mode

Update version to 9.3.11-13

685ca81

Update Mobile-Expensify submodule version to 9.3.11-13

ad29754

keep menu for CSV cards for now

e85fa7d

Merge pull request Expensify#80927 from Expensify/alberto-release33

757e1ec

[Sprint] Release 3.3 - Deleting Personal Card Feed

Merge branch 'main' into fix/74569

a5c33e8

Revert "Cleanup platform specifics from hermes build"

baf005c

Fix - Deleting IOU's in bulk shows empty report briefly

669dc9c

Merge pull request Expensify#80984 from Expensify/revert-80110-Cleanu…

6690357

…p-platform-OS-select-from-the-Hermes-bundle Revert "Cleanup platform specifics from hermes build"

Merge pull request Expensify#78271 from dmkt9/fix/74569

700efac

Fix/74569 - Deleting IOU's in bulk shows empty report briefly

Merge pull request Expensify#80918 from software-mansion-labs/feat/co…

bb2b54e

…ncierge-follow-ups-release-3-pregenerated-responses [Suggested Follow-ups][R3] Implement instant reply + optimistic reconciliation

Version bump to v9.3.11-14

5fbfaae

update submodule commit

d89b410

Merge pull request Expensify#80987 from Expensify/beaman-versionBump3

9acf728

[NoQA] Version bump to v9.3.11-14

Update version to 9.3.11-15

0e86454

Update Mobile-Expensify submodule version to 9.3.11-15

450dac4

Merge pull request Expensify#79207 from abbasifaizan70/79160

4d357ae

fix: Refetch expanded group data on toggle to prevent stale transactions after date edits

Merge pull request Expensify#80830 from TaduJR/feat-Insights-Release-…

de7edaa

…1-Top-Categories-Add-group-by-category fix: regression fixes for Top Categories (Expensify#80668, Expensify#80709)

Merge pull request Expensify#80867 from TaduJR/feat-Insights-Release-…

d674fb1

…1-Top-Categories-Add-a-limit-filter-to-search fix: [Insights] Prevent empty limit from polluting query and add description to Limit filter

Merge pull request Expensify#80634 from nkdengineer/fix/80023

0649d6e

fix: Imported contacts do not appear in the contact list

npm run prettier

3ac8656

fix types

cdcd4c8

war-in closed this Jan 30, 2026

Navigation Menu

Uh oh!

War in/domains/add vacation delegate page - #283

War in/domains/add vacation delegate page#283
war-in wants to merge 5712 commits into
feature/kuba-nowakowski/add_domain_members_details_pagefrom
war-in/domains/add-vacation-delegate-page

war-in commented Jan 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

war-in Jan 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

war-in Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

war-in commented Jan 13, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

war-in Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

war-in Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants