[Domain Control] [Release 4] Add Restrict expense workspace creation/removal Toggle to DomainGroupDetailsPage - #310
Closed
jakubstec wants to merge 557 commits into
Conversation
jakubstec
marked this pull request as draft
March 18, 2026 08:27
Swap withCurrentUserPersonalDetails HOC for the useCurrentUserPersonalDetails hook. No behavior change — both read the same Context — but removes the HOC wrapper and aligns the component with the current codebase convention. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drop the unused preferredLocale prop and read it from useLocalize() inside the component. The prop was never threaded through PureReportActionItem, so the component was silently falling back to CONST.LOCALES.DEFAULT — this change fixes that latent bug and removes one prop from the interface. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…tions
Replace the emojiReactions prop with a direct useOnyx subscription on
REPORT_ACTIONS_REACTIONS. Use the shared getEmptyObject<ReportActionReactions>()
helper for the stable empty default (matches BaseQuickEmojiReactions /
MiniQuickEmojiReactions).
Clean up the full prop chain:
- PureReportActionItem no longer takes/forwards emojiReactions; its memo loses
the deepEqual(emojiReactions) entry.
- The isOnSearch ? {} override is replaced with an !isOnSearch mount gate in the
parent, so on search we skip the mount (and the subscription) entirely.
- ReportActionItem, ReportActionsListItemRenderer, DuplicateTransactionItem and
ReportActionItemParentAction drop the prop and the now-unused useOnyx calls /
selectors that only existed to source it.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…lob URL failure restart
…reparation/draftRestoration
…for_editing_from_confirmation
[NoQA] Add the HR page Gusto card
…height-in-landscape-mode [Landscape] Fix popup content is not fully shown
refactor getReasonAndReportActionThatHasRedBrickRoad to use isOffline from useNetwork
…-spend-87974 [No QA] Update navigation terminology from "Reports" to "Spend"
[No QA] Update country list for ECUK
Update both New Expensify and Expensify Classic "Avoiding common scams" help articles to include a new section for users who receive a magic code they didn't request. The new guidance reassures users that an unrequested code alone doesn't mean their account is compromised, reminds them not to share the code, and reserves the "lock your account" recommendation for cases where the code was actually shared or the user's email is believed to be compromised. Co-authored-by: David Barrett <quinthar@users.noreply.github.com>
[CP Stag] Put spend rule summary and editing behind env guard
…bug-tax-field-missing fix: bulk edit, tax field missing for unreported expenses
…estedMagicCodeGuidance [No QA] Update help docs with proportionate guidance for unrequested magic codes
…tic-concierge-typing-updates Remove optimistic Concierge typing updates for delayed follow-up responses
…yGoogleapis Bump @sentry/webpack-plugin and googleapis with lockfile update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Add
Restrict expense workspace creation/removalsetting for Domain Security Group RHP.Fixed Issues
$ Expensify#80133
PROPOSAL:
Tests
Preconditions:
/domains/<domainAccountID>/groupsRestrict expense workspace creation/removalto trueOffline tests
N/A
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
MacOS: Chrome / Safari