[Release 4] Add Default group for new members toggle - #312
Closed
war-in wants to merge 481 commits into
Closed
Conversation
|
@war-in, |
…unt.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Account.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…unt.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…SmartScan-and-Receipt-Issues.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Account.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Account.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Account.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Account.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Account.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…martScan-Issues.md
Both sections were not guiding the agent and duplicated what the agent-device CLI's bundled skills already cover. SKILL.md is now strictly a pre-flight install gate.
…for_editing_from_confirmation
Adds two focused tests under describe('getViolatingReportIDForRBRInLHN'):
1. Processing (submitted) expense report whose only violation is a
modifiedAmount NOTICE -> getViolatingReportIDForRBRInLHN returns null.
Verifies the fix: modifiedAmount no longer bubbles up to the LHN RBR
indicator once the report enters the processing state.
2. Open expense report whose only violation is a modifiedAmount NOTICE
-> getViolatingReportIDForRBRInLHN returns the expense report ID.
Regression guard: confirms the exclusion is scoped only to processing
reports and does not over-suppress RBR for still-editable reports.
Pass EXPENSE_REPORT type to buildCannedSearchQuery per review feedback. Co-authored-by: Eric Han <eh2077@users.noreply.github.com>
The navigateToMigratedUserWelcomeModalIfReady() calls were running synchronously inside Onyx connectWithoutView callbacks, which interfered with Onyx batch processing and caused an extra render cycle in SidebarLinks perf tests. Deferring the check to the next event loop tick via setTimeout(0) with debouncing ensures it doesn't affect the current batch while still navigating promptly when conditions are met. Co-authored-by: Eric Han <eh2077@users.noreply.github.com>
…om/Expensify/App into claude-fixMigratedUserWelcomeModal Co-authored-by: Eric Han <eh2077@users.noreply.github.com>
…rWelcomeModal Co-authored-by: Eric Han <eh2077@users.noreply.github.com>
Co-authored-by: Eric Han <eh2077@users.noreply.github.com>
…ontent-cut-off Fix search content is cut off when there are filter bars
…ified-amount fix: exclude modifiedAmount NOTICE from LHN RBR for submitted reports
…atarDisappearing [CP Staging] Fix QA guide avatar disappearing when reopening admins room
Adds .github/actions/composite/isContributorPlus so other workflows can reuse the team-membership lookup. claude-review.yml now calls the composite action and reads its IS_CPLUS output instead of inlining the gh api call. Made-with: Cursor
…ramCTATapFix Fix ReferralProgramCTA text tap not responsive
…scan-pr1-selectors-getters Decompose scan pr1 selectors getters
…-pay-personal-account-no-action Fix: "Pay with personal account" does nothing in QAB expense flow
…w/block-reports-export-for-deleted-expenses Block reports export for deleted expenses
[No QA] Change file extension
…plays-section-in-save-search-page Add displays section in save search page
…serWelcomeModal Show migrated user welcome modal immediately and navigate to Home on dismiss
…e-is-shown-instead-scan-expense fix: Expense - Map expense is shown instead scan expense
…linski0/Odometer_blob_url_loss_detection [Odometer] Blob URL loss detection
…ggish-animation fix: prevent overlay dismiss during in-flight RHP transitions
…port-1 [NoQA] Remove unused exports (batch 1)
…iew-cplus-approval Run Claude PR reviewer when a Contributor+ approves a PR
Migrate SearchFiltersChatsSelector.tsx from useOptionsList to useFilteredOptions
jakubstec
force-pushed
the
war-in/domains/default-group-toggle
branch
from
April 24, 2026 06:44
4e6688f to
05a06ec
Compare
jakubstec
force-pushed
the
war-in/domains/default-group-toggle
branch
from
April 24, 2026 08:05
e98006a to
9d477f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari