Skip to content

[Release 4] Add Default group for new members toggle - #312

Closed
war-in wants to merge 481 commits into
war-in/domains/security-group-details-pagefrom
war-in/domains/default-group-toggle
Closed

[Release 4] Add Default group for new members toggle#312
war-in wants to merge 481 commits into
war-in/domains/security-group-details-pagefrom
war-in/domains/default-group-toggle

Conversation

@war-in

@war-in war-in commented Mar 16, 2026

Copy link
Copy Markdown
Member

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@rayane-d

Copy link
Copy Markdown

@war-in, SetDefaultDomainSecurityGroup command is available on staging, issue Expensify#84833 is done

stephanieelliott and others added 28 commits April 19, 2026 19:11
…unt.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Account.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…unt.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…SmartScan-and-Receipt-Issues.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Account.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Account.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Account.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Account.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Account.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Both sections were not guiding the agent and duplicated what the
agent-device CLI's bundled skills already cover. SKILL.md is now
strictly a pre-flight install gate.
Adds two focused tests under describe('getViolatingReportIDForRBRInLHN'):

1. Processing (submitted) expense report whose only violation is a
   modifiedAmount NOTICE -> getViolatingReportIDForRBRInLHN returns null.
   Verifies the fix: modifiedAmount no longer bubbles up to the LHN RBR
   indicator once the report enters the processing state.

2. Open expense report whose only violation is a modifiedAmount NOTICE
   -> getViolatingReportIDForRBRInLHN returns the expense report ID.
   Regression guard: confirms the exclusion is scoped only to processing
   reports and does not over-suppress RBR for still-editable reports.
Pass EXPENSE_REPORT type to buildCannedSearchQuery per review feedback.

Co-authored-by: Eric Han <eh2077@users.noreply.github.com>
The navigateToMigratedUserWelcomeModalIfReady() calls were running
synchronously inside Onyx connectWithoutView callbacks, which interfered
with Onyx batch processing and caused an extra render cycle in
SidebarLinks perf tests. Deferring the check to the next event loop tick
via setTimeout(0) with debouncing ensures it doesn't affect the current
batch while still navigating promptly when conditions are met.

Co-authored-by: Eric Han <eh2077@users.noreply.github.com>
…om/Expensify/App into claude-fixMigratedUserWelcomeModal

Co-authored-by: Eric Han <eh2077@users.noreply.github.com>
…rWelcomeModal

Co-authored-by: Eric Han <eh2077@users.noreply.github.com>
Co-authored-by: Eric Han <eh2077@users.noreply.github.com>
JS00001 and others added 24 commits April 23, 2026 07:25
…ontent-cut-off

Fix search content is cut off when there are filter bars
…ified-amount

fix: exclude modifiedAmount NOTICE from LHN RBR for submitted reports
…atarDisappearing

[CP Staging] Fix QA guide avatar disappearing when reopening admins room
Adds .github/actions/composite/isContributorPlus so other workflows can
reuse the team-membership lookup. claude-review.yml now calls the
composite action and reads its IS_CPLUS output instead of inlining the
gh api call.

Made-with: Cursor
…ramCTATapFix

Fix ReferralProgramCTA text tap not responsive
…scan-pr1-selectors-getters

Decompose scan pr1 selectors getters
…-pay-personal-account-no-action

Fix: "Pay with personal account" does nothing in QAB expense flow
…w/block-reports-export-for-deleted-expenses

Block reports export for deleted expenses
…plays-section-in-save-search-page

Add displays section in save search page
…serWelcomeModal

Show migrated user welcome modal immediately and navigate to Home on dismiss
…e-is-shown-instead-scan-expense

fix: Expense - Map expense is shown instead scan expense
…linski0/Odometer_blob_url_loss_detection

[Odometer] Blob URL loss detection
…ggish-animation

fix: prevent overlay dismiss during in-flight RHP transitions
…port-1

[NoQA] Remove unused exports (batch 1)
…iew-cplus-approval

Run Claude PR reviewer when a Contributor+ approves a PR
Migrate SearchFiltersChatsSelector.tsx from useOptionsList to useFilteredOptions
@jakubstec
jakubstec force-pushed the war-in/domains/default-group-toggle branch from 4e6688f to 05a06ec Compare April 24, 2026 06:44
@jakubstec
jakubstec force-pushed the war-in/domains/default-group-toggle branch from e98006a to 9d477f9 Compare April 24, 2026 08:05
@jakubstec jakubstec closed this Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.