[Domain Control] [Release 4] Add Delete Group setting to DomainGroupDetailsPage - #314
Closed
jakubstec wants to merge 875 commits into
Conversation
jakubstec
marked this pull request as draft
March 18, 2026 08:28
fix: Mark as unread doesn’t work with IOU report
…d-details [Payment due @daledah] [No QA] Fix React Compiler compliance in WorkspaceCompanyCardDetailsPage
…ec/remove-onyx-connect-policy-tags-in-transaction Remove `Onyx.connect()` usage for `ONYXKEYS.COLLECTION.POLICY_TAGS` from `changeTransactionsReport()` in `src/libs/actions/Transaction.ts`
…/86683 feat: add bulk duplicate report action to Reports search page
help site icon update
…tomFieldColumns Hide empty custom field columns in workspace members list
…iness-ba-not-here-background Fix "Not here" page opening in background for Business BA payments in offline mode
…rkspace-member-role-error [cp staging] Revert "fix: show inline member row error when workspace role update fails"
…sFailure in IOURequestStepOdometerImage/index.tsx
…sFailure in TransactionReceiptModalContent.tsx
…d03/perf-improve-IOURequestStepMerchant-marchant-onyx-update Limit re-renders after a merchant change while on the Search page
…orkspace role update fails""
…ent acronym casing
…l-greyout-after-move
…-87994-fix/workspace-member-role-error Revert "Revert "fix: show inline member row error when workspace role update fails""
…-fixMigratedUserWelcomeModal Revert "Show migrated user welcome modal immediately and navigate to Home on dismiss"
…RequestReportNavigation Avoid mounting MoneyRequestReportNavigation when unnecessary
…gnores-tax Fix: Track expense ignores tax
…auth [Payment due @huult] [Internal QA] Trigger SAML sign-in when trying to re-auth a SAML required account
Remove usages of deprecated session data from IOU/index file and refactor `createDistanceRequest`
…-biela/refactor/3ds/clean-up-reasons [ECUK In-App 3DS] refactor MFA REASON
…-selection-toolbar
…aryAction [No QA] Remove unused cpu-cores action
…ct-useParticipantSubmission-hook extract useParticipantSubmission hook
Revert "feat: Add inline editing for tables on desktop"
Refactor mergeDuplicates to pass currentUserData
…/bugfix/88238-fix-new-message-indication
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…earchGroupings
…LICY_EDUCATIONAL
…avedSearchRename [No QA] [NO QA] Docs updates for E/A#88133 Update saved search rename instructions
…urity-group-details-page-group-permissions5
… with new BE changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Add
Delete Groupsetting according to the issue linked below.Fixed Issues
$ #80133
PROPOSAL:
Tests
Preconditions:
/domains/<domainAccountID>/groups3.. Click
Delete Groupand delete a group.Delete GroupsettingOffline tests
...
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
MacOS: Chrome / Safari