Skip to content

feat: Migrate from turbo-(ios|android) to hotwire-native-(ios|android) #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025

Conversation

sztobar
Copy link
Collaborator

@sztobar sztobar commented Apr 11, 2025

Summary

  • renamed occurrences of turbo to hotwire in native packages, scripts
  • added new API method support:
  • updated screenshot handling in android implementation
  • updated react-native navigation devDependency in rn package react-native-turbo to avoid bundled version mismatch
  • bumped android minSdkVersion to required 28and configured kotlinVersion to required 1.9.25 in app.json
  • hotwire native is set to version 1.1.1 while the latest is 1.1.3. This is because later version requires kotlin 2.1.0 which is not available in this react-native version.
  • update devDependecies versions in react-native-turbo package for @react-navigation/core and @react-navigation/native from ^6.0.0 to >=6.0.0 to avoid incorrect version bundled in example app

Test plan

  • checked example-demo app for both android and ios and noticed no regressions

sztobar added 3 commits April 11, 2025 17:23
* renamed occurrences of turbo to hotwire in native packages, scripts
* added new API method support:
  * visitProposedToCrossOriginRedirect for android
  * didProposeVisitToCrossOriginRedirect for ios
* updated screenshot handling in android implementation
* updated react-native navigation devDependency in rn package react-native-turbo to avoid bundled version mismatch
* bumped android minSdkVersion to required `28`and configured kotlinVersion to required `1.9.25` in app.json
* hotwire native is set to version `1.1.1` while the latest is `1.1.3`. This is because later version requires kotlin
`2.1.0` which is not available in this react-native version.
@pklatka
Copy link
Collaborator

pklatka commented Apr 14, 2025

I can't run example app on a freshly-cloned repo, could you please clone the repository and check if the error is present on your side when running the example app on Android (see the screenshot)?
image

Small note: you can consider upgrading this, not necessarily in this PR
image

@sztobar
Copy link
Collaborator Author

sztobar commented Apr 16, 2025

@pklatka are you certain that you've run the demo app using this branch? I double-checked and I noticed that this issue happens on main branch, this branch fixes the issue by updating react-navigation devDependencies in packages from ^6 to >=6. Because this branch is the next invevitable upgrade I haven't created separate PR to fix that and decide to include this here.

Regarding turbo - thanks for the heads up, I'll create separate PR to fix that. I wanted to do some cleaning with peerDependencies, there are a lot of warning when installing dependencies.

Copy link
Collaborator

@pklatka pklatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked and indeed the app works on Android, my bad. Code looks ok!

@pfeiffer
Copy link
Contributor

Completed QA of this in our app and found no issues. Great!

@sztobar sztobar merged commit 6ec163c into main Apr 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants