Skip to content

Update project dependencies #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update project dependencies #222

wants to merge 4 commits into from

Conversation

sztobar
Copy link
Collaborator

@sztobar sztobar commented Apr 24, 2025

Summary

  • update turbo from 1.13.3 to 2.5.0
  • rename example demo app scripts:
    • lint:check into lint
    • tsc:check into typescript
      to match packages scripts. Now running yarn lint or yarn typescript will run it for both packages and example app as well.
  • added strict: true to example tsconfig.json for better type-checking and fixed issues that were caused by introducing strict mode.
  • fix turbo postinstall script that run from examples/turbo-demo-expo-example on consecutive yarn install when turbo cache misses.

Test plan

  • built both apps and verified that there's no regressions

@sztobar sztobar requested a review from pklatka April 24, 2025 14:28
PARENT_FOLDER=$(realpath .. | awk -F/ '{print $NF}')

if [ "$PARENT_FOLDER" = "node_modules" ]; then
# skip postinstall for `yarn install` called from inside `turbo-demo-expo-example`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT - other comments start with uppercase letter

Suggested change
# skip postinstall for `yarn install` called from inside `turbo-demo-expo-example`
# Skip postinstall for `yarn install` called from inside `turbo-demo-expo-example`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants