RNSession: Fix the decidePolicyFor handler
#225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Native. Remove unused delegate method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the navigation policy handler after upgrading to Hotwire Native iOS 1.2
In particular, we now implement the same policies as Hotwire Native and call the RN method correctly, letting that handle the actual opening of external URLs (by cancelling the request).
It also removes the unused delegate method from Turbo Native iOS which doesn't exist in Hotwire Native.
Test plan
Can be tested by tapping an external link or a link that requests a blank window.
Also tested on a page that contains an iframe (which previously would trigger the RN-side method) and confirm that it doesn't.