Android: Avoid doubble-triggering the LOAD event
#235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes double-calling of
onLoadon Android.The
LOADevent is triggered invisitRendered. ThevisitRenderedcallback is triggered both when restoring and when advancing by Hotwire Native.The
visitCompletedis called when a web page has been loaded in the WebView.The
onLoadcallback could be fired twice - once viavisitCompletedand once viavisitRendered. This PR addresses that by only firing it viavisitRenderedwhich brings the behavior in-line with iOS.Test plan
Add a log statement to
onLoad. Test on Android and open a screen and navigate around.Before
After