Fix race condition in Strada initialization #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a potential calling of
window.nativeBridgeto register Strada components before the bridge is actually initialized.In the Strada initialization script, we have the following snippet to initialize the bridge:
This method is called dependent on the
document.readyStateor onDOMContentLoaded.This means that
window.nativeBridgecould be undefined when we register the components of the Strada bridge from the React Native side.This PR changes so that we register the available components at the same time as we initialize the bridge, making sure that the window.nativeBridge is available when we call that.
Test plan
Run app with Strada components, confirm that they work.