@typegpu/geometry Improve line rendering APIs#2470
Open
deluksic wants to merge 1 commit intosoftware-mansion:mainfrom
Open
@typegpu/geometry Improve line rendering APIs#2470deluksic wants to merge 1 commit intosoftware-mansion:mainfrom
deluksic wants to merge 1 commit intosoftware-mansion:mainfrom
Conversation
deluksic
force-pushed
the
de/improve-line-rendering-api
branch
from
88e23e0 to
1b5ba58
Compare
deluksic
commented
May 8, 2026
| label: getName(this) ?? '<unnamed>', | ||
| format: props.format, | ||
| size: props.size, | ||
| size: [...props.size], |
Contributor
Author
There was a problem hiding this comment.
I was getting some type issues in my strict codebase, not sure if you want to fix it upstream.
deluksic
commented
May 8, 2026
|
|
||
| functionDefinition(options: FunctionDefinitionOptions): string; | ||
| typeInstantiation(schema: BaseData, args: readonly Snippet[]): ResolvedSnippet; | ||
| typeInstantiation(schema: BaseData, args: readonly (Snippet | undefined)[]): ResolvedSnippet; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed and reordered the APIs a bit, and allow customization of arrow caps.
lineSegmentVariableWidth(vertexIndex, A, B, C, D, MAX_JOIN_COUNT)->polylineVariableWidth(A, B, C, D, vertexIndex, MAX_JOIN_COUNT)lineVariableWidth(A, B, vertexIndex, MAX_JOIN_COUNT)New
arrowCapParamsSlot, one can change arrow cap sizes: