Support nvm via .nvmrc file detection #1610

Copilot · 2025-10-03T09:20:33Z

Adds support for nvm via .nvmrc file detection. Some projects (i.e. bsky) use .nvmrc file to specify the node version. Currently, the only way to make Radon honor that file would be to go to the project directory, run nvm use and then launch code from the terminal. This isn't ideal especially for people who work on a couple of different projects with different node version requirements.

This change runs nvm use similarly to how we initialize PATH variables to support tools like mise.

Fixes #1609

Changes Made

Modified packages/vscode-extension/src/utilities/subprocess.ts:

Added a dry-run approach to test if nvm is available and properly configured before including it in the command chain
Refactored command generation to use a commands array with .join(" && ") for better readability:
- cd to app root is always included
- nvm use is conditionally added only if the dry-run succeeds
- echo to capture PATH is always included
Maintains proper error handling throughout the command chain

Implementation Details

The solution uses a dry-run approach to optimize performance and avoid unnecessary error messages:

Dry-run test: First attempts to run nvm use in the application root directory
Conditional inclusion: Only includes nvm use in the actual PATH command if the dry-run succeeds
Graceful handling: If nvm is not installed, not configured, or no .nvmrc file exists, the dry-run fails and nvm is skipped entirely
Command chain generation: Uses an array of commands joined with .join(" && ") for clear, maintainable code

This means:

Projects with .nvmrc → nvm use runs and loads the correct version ✅
Projects without .nvmrc → nvm is skipped (no error messages in logs) ✅
Systems without nvm → nvm commands are not attempted ✅

How Has This Been Tested:

✅ Prettier formatting passes
✅ Dry-run succeeds with .nvmrc present → nvm use is included
✅ Dry-run fails without .nvmrc → nvm use is skipped
✅ Dry-run fails without nvm → command is skipped
✅ If cd fails, the entire command chain stops (correct behavior)
✅ If cd succeeds, nvm use runs (if available), then echo runs (correct behavior)
✅ Proper error propagation maintained with && chaining

How Has This Change Been Documented:

N/A - This is an internal enhancement that automatically detects and uses .nvmrc files when present, requiring no user documentation.

Original prompt

This section details on the original issue you should resolve

<issue_title>Support nvm (via .nvmrc file)</issue_title>
<issue_description>Some projects (i.e. bsky) use .nvmrc file to specify the node version. Currently, the only way to make Radon honor that file would be to go to the project directory, run nvm use and then launch code from the terminal. This isn't ideal especially for people who work on a couple of different projects with different node version requirements.

We should run nvm use similarily to how we initialize PATH variables to support tools like mise. </issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #1609

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

vercel · 2025-10-03T09:20:39Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
radon-ide	Ready	Preview	Comment	Dec 12, 2025 4:18pm

kmagiera · 2025-10-03T13:10:25Z

packages/vscode-extension/src/utilities/subprocess.ts

+  // If .nvmrc exists, run 'nvm use' to load the correct Node.js version.
+  // We use a conditional command that only runs 'nvm use' if nvm is available,
+  // preventing errors in environments where nvm is not installed.
+  const nvmCommand = hasNvmrc ? "type nvm > /dev/null 2>&1 && nvm use; " : "";


what is the reason we only call nvm use when the file is present? given we can handle the case the commend throws, maybe it'd be better to just call it here instead of testing agains the .nvmrc file

You're absolutely right. I've removed the .nvmrc file check since nvm use itself handles the case gracefully when the file is not present. The command now always runs type nvm > /dev/null 2>&1 && nvm use; which is simpler and works correctly in all scenarios.

Changes in commit 1a53e76

filip131311

@copilot what is the reason we only call nvm use when the file is present? given we can handle the case the commend throws, maybe it'd be better to just call it here instead of testing agains the .nvmrc file

jwajgelt · 2025-10-08T08:47:22Z

packages/vscode-extension/src/utilities/subprocess.ts

+  // If .nvmrc exists, run 'nvm use' to load the correct Node.js version.
+  // We use a conditional command that only runs 'nvm use' if nvm is available,
+  // preventing errors in environments where nvm is not installed.
+  const nvmCommand = hasNvmrc ? "type nvm > /dev/null 2>&1 && nvm use; " : "";


@copilot I think it'd be better to dry-run nvm use once to check if it's set up correctly, and then add it to the execa call below only if successful.

Good suggestion! I've implemented the dry-run approach. Now nvm use is tested first with an execa call, and only included in the actual PATH command if it succeeds. This means projects without .nvmrc won't see error messages, and systems without nvm won't attempt to use it.

Changes in commit c0ef927

Copilot · 2025-10-08T08:49:15Z

@copilot what is the reason we only call nvm use when the file is present? given we can handle the case the commend throws, maybe it'd be better to just call it here instead of testing agains the .nvm...

Good point! I've simplified the implementation to always call nvm use without checking for the .nvmrc file first. The nvm use command handles missing files gracefully, so the extra filesystem check wasn't necessary.

Changes in commit 1a53e76

jwajgelt · 2025-10-10T13:04:46Z

packages/vscode-extension/src/utilities/subprocess.ts

      "-l",
      "-c",
-      `cd "${appRoot}" && echo "${RNIDE_PATH_DELIMITER}$PATH${RNIDE_PATH_DELIMITER}"`,
+      `cd "${appRoot}" && ${nvmCommand}echo "${RNIDE_PATH_DELIMITER}$PATH${RNIDE_PATH_DELIMITER}"`,


@copilot since the nvmCommand ends with ;, won't that change the behavior to not fail if cd appRoot didn't succeed?

You're absolutely right! The semicolon breaks the error chain. With ;, the echo command would run even if cd fails. I've changed it to use && instead, so the entire command chain properly fails if cd doesn't succeed.

Changes in commit 07a1cf8

@copilot can you change this so that

you generate a list of commands to run in the chain

you always have cd and echo commands on the list

you only include nvm use if nvm is available

you generate the final command chain by calling .join(" && ") on that list?
I think it would be more readable that way.

Done. Refactored to use a commands array that always includes cd and echo, conditionally adds nvm use if available, and generates the final command with .join(" && ").

Changes in commit e52ae3c

jwajgelt · 2025-12-02T14:28:26Z

@copilot can you rebase this branch onto main?

Copilot · 2025-12-02T14:29:42Z

@copilot can you rebase this branch onto main?

I'm unable to rebase this branch as I don't have the ability to perform git rebase operations or force push. You'll need to rebase this branch manually, or I can help with other changes if needed.

jwajgelt · 2025-12-02T14:31:26Z

@copilot can you rebase this branch onto main?

I'm unable to rebase this branch as I don't have the ability to perform git rebase operations or force push. You'll need to rebase this branch manually, or I can help with other changes if needed.

@copilot merge main into this branch then

Copilot · 2025-12-02T14:33:29Z

@copilot can you rebase this branch onto main?

I'm unable to rebase this branch as I don't have the ability to perform git rebase operations or force push. You'll need to rebase this branch...

Done. Merged main into this branch in commit 853377b.

jwajgelt

LGTM

I don't have an up to date assesment of this PR but it seems to be blocked by my old review so i dismiss it

The request has been addressed.

Found some issues, will fix them manually

Co-authored-by: kmagiera <[email protected]>

Co-authored-by: filip131311 <[email protected]>

Co-authored-by: jwajgelt <[email protected]>

jwajgelt

Seems to work fine now.

Copilot AI assigned Copilot and kmagiera Oct 3, 2025

Copilot started work on behalf of kmagiera October 3, 2025 09:20 View session

vercel bot deployed to Preview October 3, 2025 09:20 View deployment

vercel bot deployed to Preview October 3, 2025 09:33 View deployment

Copilot AI changed the title ~~[WIP] Support nvm (via .nvmrc file)~~ Support nvm via .nvmrc file detection Oct 3, 2025

Copilot AI requested a review from kmagiera October 3, 2025 09:44

Copilot finished work on behalf of kmagiera October 3, 2025 09:44

kmagiera previously requested changes Oct 3, 2025

View reviewed changes

filip131311 previously requested changes Oct 8, 2025

View reviewed changes

Copilot started work on behalf of filip131311 October 8, 2025 08:46 View session

jwajgelt requested changes Oct 8, 2025

View reviewed changes

vercel bot deployed to Preview October 8, 2025 08:49 View deployment

Copilot AI requested a review from filip131311 October 8, 2025 08:50

Copilot finished work on behalf of filip131311 October 8, 2025 08:50

Copilot started work on behalf of jwajgelt October 8, 2025 08:50 View session

vercel bot deployed to Preview October 8, 2025 08:53 View deployment

Copilot AI requested a review from jwajgelt October 8, 2025 08:54

Copilot finished work on behalf of jwajgelt October 8, 2025 08:54

jwajgelt reviewed Oct 10, 2025

View reviewed changes

Copilot started work on behalf of jwajgelt October 10, 2025 13:05 View session

vercel bot deployed to Preview October 10, 2025 13:07 View deployment

Copilot AI requested a review from jwajgelt October 10, 2025 13:07

Copilot finished work on behalf of jwajgelt October 10, 2025 13:07

Copilot started work on behalf of jwajgelt December 2, 2025 14:23 View session

vercel bot deployed to Preview December 2, 2025 14:27 View deployment

Copilot finished work on behalf of jwajgelt December 2, 2025 14:27

Copilot started work on behalf of jwajgelt December 2, 2025 14:28 View session

Copilot finished work on behalf of jwajgelt December 2, 2025 14:31

Copilot started work on behalf of jwajgelt December 2, 2025 14:31 View session

Copilot finished work on behalf of jwajgelt December 2, 2025 14:34

vercel bot deployed to Preview December 2, 2025 14:35 View deployment

jwajgelt marked this pull request as ready for review December 2, 2025 14:39

jwajgelt requested a review from kmagiera December 2, 2025 14:39

jwajgelt previously approved these changes Dec 2, 2025

View reviewed changes

jwajgelt self-requested a review December 3, 2025 08:38

jwajgelt marked this pull request as draft December 3, 2025 09:12

Copilot AI and others added 6 commits December 12, 2025 17:17

Initial plan

dd04998

Support nvm via .nvmrc file detection

59ca9ee

Co-authored-by: kmagiera <[email protected]>

Remove unnecessary .nvmrc file check - always call nvm use

fbf5c19

Co-authored-by: filip131311 <[email protected]>

Dry-run nvm use before including in PATH command

3a166d4

Co-authored-by: jwajgelt <[email protected]>

Fix: use && instead of ; to maintain error chain in nvm command

9fbc6a4

Co-authored-by: jwajgelt <[email protected]>

Refactor: Use commands array with .join(" && ") for better readability

3d3cfb8

Co-authored-by: jwajgelt <[email protected]>

jwajgelt force-pushed the copilot/fix-d8ea27f3-5f01-43da-bc77-79fafb89d962 branch from 853377b to 3d3cfb8 Compare December 12, 2025 16:17

vercel bot deployed to Preview December 12, 2025 16:18 View deployment

jwajgelt marked this pull request as ready for review December 12, 2025 16:18

jwajgelt approved these changes Dec 15, 2025

View reviewed changes

jwajgelt merged commit f492c87 into main Dec 15, 2025
9 checks passed

jwajgelt deleted the copilot/fix-d8ea27f3-5f01-43da-bc77-79fafb89d962 branch December 15, 2025 08:40

Support nvm via .nvmrc file detection #1610

Support nvm via .nvmrc file detection #1610

Uh oh!

Conversation

Copilot AI commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

Implementation Details

How Has This Been Tested:

How Has This Change Been Documented:

Comments on the Issue (you are @copilot in this section)

Uh oh!

vercel bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kmagiera Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

filip131311 left a comment

Choose a reason for hiding this comment

Uh oh!

jwajgelt Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Oct 8, 2025

Uh oh!

jwajgelt Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

jwajgelt Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

jwajgelt commented Dec 2, 2025

Uh oh!

Copilot AI commented Dec 2, 2025

Uh oh!

jwajgelt commented Dec 2, 2025

Uh oh!

Copilot AI commented Dec 2, 2025

Uh oh!

jwajgelt left a comment

Choose a reason for hiding this comment

Uh oh!

jwajgelt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Oct 3, 2025 •

edited

Loading

vercel bot commented Oct 3, 2025 •

edited

Loading