tests: Tests stability improvements and code refactor #1802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jwajgelt
approved these changes
Dec 11, 2025
| if (!appWebsocket) { | ||
| reject(new Error("No websocket connection")); | ||
|
|
||
| if (!appWebsocket || appWebsocket.readyState !== 1) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!appWebsocket || appWebsocket.readyState !== 1) { | |
| if (!appWebsocket || appWebsocket.readyState !== WebSocket.OPEN) { |
| reject( | ||
| new Error( | ||
| `Websocket not connected or not ready. State: ${ | ||
| appWebsocket ? appWebsocket.readyState : "null" |
Contributor
There was a problem hiding this comment.
NIT:
Isn't this the same as
Suggested change
| appWebsocket ? appWebsocket.readyState : "null" | |
| appWebsocket?.readyState |
Comment on lines
61
to
68
| try { | ||
| const msg = JSON.parse(message); | ||
| if (msg.id === id) { | ||
| clearTimeout(timer); | ||
| appWebsocket.off("message", handler); | ||
| resolve(msg); | ||
| } | ||
| } catch (e) {} |
Contributor
There was a problem hiding this comment.
Should we really just ignore the errors from parsing message here? It would seem to me that it indicates a bug in the tests, and should be reported.
| const fullPath = path.join(process.cwd(), "data", filename); | ||
| await quickInput.sendKeys(fullPath); | ||
| await this.driver.sleep(TIMEOUTS.SHORT); | ||
| // await quickInput.sendKeys(Key.ENTER); |
Contributor
There was a problem hiding this comment.
remove the comment, or uncomment the line if it was removed by mistake
Suggested change
| // await quickInput.sendKeys(Key.ENTER); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces significant stability improvements to address flaky CI tests. While further optimizations may be required, this PR is being submitted now due to its increasing size. Additionally, it includes code refactoring to improve readability.
How Has This Been Tested:
Tests have been executed on local CI. They seem to work much better after changes.
How Has This Change Been Documented:
No documentation changes are required.