feat: collapse unused section of launch configuration dropdown #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
filip131311
commented
Dec 10, 2025
packages/vscode-extension/src/webview/components/AppRootSelect.tsx
Outdated
Show resolved
Hide resolved
jwajgelt
requested changes
Dec 10, 2025
Contributor
jwajgelt
left a comment
jwajgelt
left a comment
There was a problem hiding this comment.
Good idea, but I have issues with the implementation.
Comment on lines
+49
to
+50
| isExpanded: boolean, | ||
| onToggleExpand: () => void, |
Contributor
There was a problem hiding this comment.
I think this function should be made into a full-blown component, and these should be the internal state of that component, rather than arguments that are passed through three separate functions.
Collaborator
Author
There was a problem hiding this comment.
sure Ill cook it in a minute
jwajgelt
approved these changes
Dec 10, 2025
jwajgelt
pushed a commit
that referenced
this pull request
Dec 12, 2025
This PR collapses the "detected" or "custom" section of launch
configuration depending on which one is currently selected
this should improve a user experience for users that have a lot of
custom configurations and the "detected" section is cluttering their
already large selection.
Moreover for the first setup we select the custom configuration if
exists:
```js
// Otherwise, return the first launch config or a default one
if (this._launchConfigurations.length > 0) {
return this._launchConfigurations[0];
}
```
so for enterprise projects with already existing configurations the user
should never have a need to expand the "detected" section
### How Has This Been Tested:
https://github.com/user-attachments/assets/0d3a21b0-b821-4e83-aedd-ccb58e97e2d6
### How Has This Change Been Documented:
nah
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collapses the "detected" or "custom" section of launch configuration depending on which one is currently selected
this should improve a user experience for users that have a lot of custom configurations and the "detected" section is cluttering their already large selection.
Moreover for the first setup we select the custom configuration if exists:
so for enterprise projects with already existing configurations the user should never have a need to expand the "detected" section
How Has This Been Tested:
Screen.Recording.2025-12-10.at.11.21.10.mov
How Has This Change Been Documented:
nah