fix: Fix extension crashing on startup #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Member
Author
|
Of course feel free to merge this without waiting for me |
latekvo
changed the title
latekvo
changed the title
jwajgelt
deleted the
@latekvo/fix-extension-always-crashing-on-startup
branch
jwajgelt
pushed a commit
that referenced
this pull request
Dec 12, 2025
Extension crashes on startup. This PR fixes that. This was happening because `workspace.getConfiguration();` (located in `getEditorType();`) was being called before `setExtensionContext(context);`. <img width="914" height="152" alt="image" src="https://github.com/user-attachments/assets/adc99ef2-7518-4b2e-9e79-925b70ca3fa6" /> ### How Has This Been Tested: - Start the extension - The panel works, and no errors are thrown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension crashes on startup. This PR fixes that.
This was happening because
workspace.getConfiguration();(located ingetEditorType();) was being called beforesetExtensionContext(context);.How Has This Been Tested: