feat: add seasonal visual improvements #1820
Conversation
…esponsive dimensions
…ate and star generation logic
…plement festive features
…Loader feat: import FestiveSnow component in PreviewView for festive enhancements
…ction refactor: remove unnecessary blank lines in PreviewView
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| import { use$ } from "@legendapp/state/react"; | ||
| import { useStore } from "../../providers/storeProvider"; | ||
|
|
||
| function isChristmasSeason(): boolean { |
There was a problem hiding this comment.
If it's behind a switch let just make it available without any date based limitations. We will remove this code in first update in 2026 anyway
Also, the setting is persistent so once we hide the switch in Jan people who had it on, won't be able to turn it off
There was a problem hiding this comment.
This change was not made persistent (between extension sessions), exactly for the reason stated above, so that we would not accidentally leave people in this mode without an option to turn it off.
If we plan to explicitly clean up the changes after, making them persistent across extension openings would require minimal extra work.
There was a problem hiding this comment.
I think it'd be nice to keep it saved if someone enabled it. We will cleanup the code later so with some future update it will be switched off entirely.
There was a problem hiding this comment.
Made persistent and removed the date limitations in 87da971.
### Description Add optional seasonal visuals, toggleable between 19th December and 20th of January. ### How Has This Been Tested: Verified that toggle does not display in incorrect time periods, made sure the visual changes look good, made sure the visuals are not obstructive. ### How Has This Change Been Documented: Not applicable.
This reverts commit fa86790.
This reverts commit 894950b.
Description
Add optional seasonal visuals, toggleable between 19th December and 20th of January.
How Has This Been Tested:
Verified that toggle does not display in incorrect time periods, made sure the visual changes look good, made sure the visuals are not obstructive.
How Has This Change Been Documented:
Not applicable.