Skip to content

fix: use namespace instead of appId when generating MainActivity #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwajgelt merged 2 commits into from
Jan 7, 2026
Merged

fix: use namespace instead of appId when generating MainActivity #1830

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0db39a3
fix: use package name instead of appId when generating Activity from …
jwajgelt Dec 19, 2025
85b7b8d
add missing capture group
jwajgelt Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions packages/vscode-extension/src/builders/buildAndroid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import path from "path";
import semver from "semver";
import { AndroidConfig } from "@expo/config-plugins";
import loadConfig from "@react-native-community/cli-config";
import { getAppBuildGradleAsync } from "@expo/config-plugins/build/android/Paths.js";
import { calculateAppArtifactHash, getNativeABI } from "../utilities/common";
import { ANDROID_HOME, findJavaHome } from "../utilities/android";
import { Logger } from "../Logger";
Expand Down Expand Up @@ -81,19 +82,28 @@ async function getApplicationManifest(
return undefined;
}

async function getNamespaceFromGradle(projectRoot: string): Promise<string | null> {
const gradleBuild = await getAppBuildGradleAsync(projectRoot);
if (!gradleBuild) {
return null;
}

// The namespace field in build.gradle defines the Java package name for the app's code.
const matchResult = gradleBuild.contents.match(/namespace\s+['"](.*)['"]/);
return matchResult?.[1] ?? null;
Copy link
Collaborator

@filip131311 filip131311 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't it always return null? there is no capture group (()) defined in the regex so you will match but you want get the name space name

Copy link
Contributor Author

@jwajgelt jwajgelt Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right.
It must've worked for me due to falling back to some other fallback handing it.

}

async function resolveAppIdFromNative(projectRoot: string): Promise<string | null> {
const applicationIdFromGradle = await AndroidConfig.Package.getApplicationIdAsync(
projectRoot
).catch(() => null);
if (applicationIdFromGradle) {
return applicationIdFromGradle;
const namespaceFromGradle = await getNamespaceFromGradle(projectRoot);
if (namespaceFromGradle) {
return namespaceFromGradle;
}

try {
const filePath = await AndroidConfig.Paths.getAndroidManifestAsync(projectRoot);
const androidManifest = await AndroidConfig.Manifest.readAndroidManifestAsync(filePath);
// Assert MainActivity defined.
await AndroidConfig.Manifest.getMainActivityOrThrow(androidManifest);
AndroidConfig.Manifest.getMainActivityOrThrow(androidManifest);
const appId = androidManifest.manifest?.$?.package;
if (appId) {
return appId;
Expand All @@ -111,10 +121,14 @@ async function getLaunchActivity(
baseAppId: string
): Promise<string | undefined> {
const manifest = await getApplicationManifest(projectRoot);
if (!manifest) return undefined;
if (!manifest) {
return undefined;
}

const mainActivity = await AndroidConfig.Manifest.getRunnableActivity(manifest);
if (!mainActivity) return undefined;
const mainActivity = AndroidConfig.Manifest.getRunnableActivity(manifest);
if (!mainActivity) {
return undefined;
}

const mainActivityName = mainActivity.$["android:name"];

Expand Down
Loading