Skip to content

fix: android manifest config generated by plugin #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdydek merged 2 commits into from
Jan 16, 2026
Merged

fix: android manifest config generated by plugin #894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d392137
fix: android manifest config generated by plugin
michalsek Jan 16, 2026
8a67aad
fix: require permissions on module level
michalsek Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/fabric-example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3291,7 +3291,7 @@ SPEC CHECKSUMS:
FBLazyVector: 309703e71d3f2f1ed7dc7889d58309c9d77a95a4
fmt: a40bb5bd0294ea969aaaba240a927bd33d878cdd
glog: 5683914934d5b6e4240e497e0f4a3b42d1854183
hermes-engine: f93b5009d8ccd9429fe2a772351980df8a22a413
hermes-engine: 42d6f09ee6ede2feb220e2fb772e8bebb42ca403
RCT-Folly: 846fda9475e61ec7bcbf8a3fe81edfcaeb090669
RCTDeprecation: a41bbdd9af30bf2e5715796b313e44ec43eefff1
RCTRequired: 7be34aabb0b77c3cefe644528df0fa0afad4e4d0
Expand Down
2 changes: 1 addition & 1 deletion packages/audiodocs/docs/inputs/audio-recorder.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Additionally to be able to record audio while application is in the background,
<uses-permission android:name="android.permission.RECORD_AUDIO"/>

<!-- Paste this inside <application> tag -->
<service android:stopWithTask="true" android:name="com.swmansion.audioapi.system.MediaNotificationManager$AudioForegroundService" android:foregroundServiceType="microphone" />
<service android:stopWithTask="true" android:name="com.swmansion.audioapi.system.CentralizedForegroundService" android:foregroundServiceType="microphone" />
</manifest>

```
Expand Down
2 changes: 2 additions & 0 deletions ...ges/react-native-audio-api/android/src/main/java/com/swmansion/audioapi/AudioAPIModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.swmansion.audioapi

import androidx.annotation.RequiresPermission
import com.facebook.jni.HybridData
import com.facebook.react.bridge.Arguments
import com.facebook.react.bridge.LifecycleEventListener
Expand Down Expand Up @@ -149,6 +150,7 @@ class AudioAPIModule(
}

// Notification system methods
@RequiresPermission(android.Manifest.permission.POST_NOTIFICATIONS)
override fun showNotification(
type: String?,
key: String?,
Expand Down
16 changes: 12 additions & 4 deletions packages/react-native-audio-api/src/plugin/withAudioAPI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import {
AndroidConfig,
createRunOncePlugin,
ConfigPlugin,
withInfoPlist,
createRunOncePlugin,
withAndroidManifest,
withGradleProperties,
withInfoPlist,
withPodfile,
} from '@expo/config-plugins';
const pkg = require('react-native-audio-api/package.json');
Expand Down Expand Up @@ -75,7 +75,7 @@ const withForegroundService: ConfigPlugin<Options> = (
const serviceElement = {
$: {
'android:name':
'com.swmansion.audioapi.system.MediaNotificationManager$AudioForegroundService',
'com.swmansion.audioapi.system.CentralizedForegroundService',
'android:stopWithTask': 'true',
'android:foregroundServiceType': SFTypes,
},
Expand All @@ -86,8 +86,16 @@ const withForegroundService: ConfigPlugin<Options> = (
mainApplication.service = [];
}

mainApplication.service.push(serviceElement);
const existingServiceIndex = mainApplication.service.findIndex((service) =>
service.$['android:name'].includes(serviceElement.$['android:name'])
);

if (existingServiceIndex !== -1) {
mainApplication.service[existingServiceIndex] = serviceElement;
return mod;
}

mainApplication.service.push(serviceElement);
return mod;
});
};
Expand Down