fix: Attempt to fix EXC_BAD_ACCESS in AnimatedPropsRegistry::update via AnimationFrameBatchinator::flush#9306
Open
fix: Attempt to fix EXC_BAD_ACCESS in AnimatedPropsRegistry::update via AnimationFrameBatchinator::flush#9306
EXC_BAD_ACCESS in AnimatedPropsRegistry::update via AnimationFrameBatchinator::flush#9306Conversation
MatiPl01
force-pushed
the
@matipl01/fix-animated-props-update-race
branch
from
53b89c7 to
c753917
Compare
MatiPl01
force-pushed
the
@matipl01/fix-animated-props-update-race
branch
from
c753917 to
548415f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since the original issue is not reproducible, I can't guarantee that this PR actually fixes the issue. It adds one mutex that seems to be necessary.