Conversation
MatiPl01
changed the base branch from
main
to
@matipl01/fix-stuttering-layout-animations
MatiPl01
force-pushed
the
@matipl01/fix-stuttering-layout-animations
branch
from
4968559 to
7f62d63
Compare
MatiPl01
force-pushed
the
@matipl01/fix-layout-animation-flush-race
branch
from
62f68d1 to
236ccfe
Compare
MatiPl01
changed the base branch from
@matipl01/fix-stuttering-layout-animations
to
main
|
Thanks @MatiPl01 , appreciate the quick turnaround, happy to ship the fix as soon as it lands. |
Member
Author
|
@stage88 Thanks! If you have a chance to test it somehow and tell me if it works for you, I'd appreciate that. |
|
Unfortunately I am unable to repro the crash my self, however the crash continues despite releasing another version with a few of the core deps upgraded. I am happy to release the code change as a patch if we could get it reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since the original issue is not reproducible, I can't guarantee that this PR actually fixes the issue. It adds some mutexes that seem to be necessary.