Unify incremental_create_output_dir

[DelevoXDG]

Stack

• Bump Cairo #2886
• Save scarb execute outputs #2869
• Unify incremental_create_output_dir #2870
• Support runnable code blocks in docs #2876
• Add support for should_panic and compile_fail doc-test attributes #2893

---

[maciektr]

Nit: Maybe just scarb-fs-utils? 🤔 Seems general enough to me.

[maciektr]

I'd just keep them where they are used.

[DelevoXDG]

I moved them here so we could re-use these both in scarb execute and scarb doc in #2876.

Can define these in both places, but not sure why?

IMO it's reasonable to keep this crate as scarb execute utils rather then general. If we do, it makes sense to keep those here.

[maciektr]

Let's just take execution as param.

Suggested change

	pub fn incremental_create_execution_output_dir(path: &Utf8Path) -> Result<(Utf8PathBuf, usize)> {
	pub fn incremental_create_dir_unique(path: &Utf8Path, name: &str) -> Result<(Utf8PathBuf, usize)> {

[DelevoXDG]

I'm not sure we expect incremental_create_dir_unique to be used in any other contexts? 🤔

If we don't, it seems reasonable to me to keep this crate scarb execute-focused.

[maciektr]

it seems reasonable to me to keep this crate scarb execute-focused

I'd look at this from the other side, that is, it makes sense to me to define some crate for how Scarb interacts with the filesystem. E.g. canonicalization helpers from internal/fsx.rs could go there in the future - this is not Scarb specific, and would make sense in the extensions as well.