Replace precompiled ledger app binary with CI build and fork `speculos-client` with support for `2.4.0` starknet app by MKowalski8 · Pull Request #147 · software-mansion/starknet-rust

MKowalski8 · 2026-05-19T23:13:39Z

Towards foundry-rs/starknet-foundry#4221

Introduced changes

Remove precompiled binarires
Bump ledger app version to 2.4.0
Introudce new package in utils with support for 2.4.0 ledger app with speculos

Checklist

Linked relevant issue
Added relevant tests
Performed self-review of the code
Added changes to CHANGELOG.md

MKowalski8 · 2026-05-20T09:55:23Z

For reference https://github.com/xJonathanLEI/speculos-client

ddoktorski · 2026-05-25T10:25:16Z

+          git clone --depth 1 --branch nanox_2.7.0_2.4.0_sdk_v26.0.2 \
+            https://github.com/LedgerHQ/app-starknet /tmp/app-starknet
+          cd /tmp/app-starknet/starknet
+          cargo +${RUST_NIGHTLY} ledger build nanox


Where is RUST_NIGHTLY set and why is it used here?

It's set in the ledger-app-builder Dockerfile. And to run ledger build we need nightly version, because from what I've checked it uses -Z build-std which needs nightly.

Maybe add a comment that it's defined there?

ddoktorski · 2026-05-25T10:40:48Z

+                if line.contains("launcher: using default app name & version")
+                    || line.contains("[*] Env app version:")


It seems quite fragile, if output changes it will hang forever. Can we add some kind of a timeout here?

Actually I've encountered this, but didn't want to make to much changes here. But yeah, it's a good idea, will do.

I changed the logic a little bit, added some extra checks and better error handling as well

ddoktorski · 2026-05-29T08:14:29Z

+          git clone --depth 1 --branch nanox_2.7.0_2.4.0_sdk_v26.0.2 \
+            https://github.com/LedgerHQ/app-starknet /tmp/app-starknet
+          cd /tmp/app-starknet/starknet
+          cargo +${RUST_NIGHTLY} ledger build nanox


Maybe add a comment that it's defined there?

ddoktorski · 2026-05-29T08:15:13Z

+pub async fn set_automation(client: &SpeculosClient, rules: &[AutomationRule<'static>]) {
+    client.automation(rules).await.unwrap();
+    if rules.iter().any(|r| r == &ENABLE_BLIND_SIGN) {
+        client.click_button(Button::Right).await.unwrap();


Would it be possible to return Result here instead of panic?

ddoktorski · 2026-05-29T08:19:00Z

Let's add some doc comments in this file. Not to every single struct or method, but at least to the most important ones

Replace precompiled ledger app binary with CI build

45fbdbe

MKowalski8 force-pushed the mkowalski/ledger-app-build branch 4 times, most recently from 5348be5 to 63c9a85 Compare May 20, 2026 09:14

Move automation rules to helper crate

4756455

MKowalski8 force-pushed the mkowalski/ledger-app-build branch from 63c9a85 to 4756455 Compare May 20, 2026 09:31

MKowalski8 commented May 20, 2026

View reviewed changes

Comment thread utils/speculos-client/Cargo.toml Outdated

MKowalski8 commented May 20, 2026

View reviewed changes

Comment thread utils/speculos-client/src/lib.rs

Copy link
Copy Markdown

Member Author

MKowalski8 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference https://github.com/xJonathanLEI/speculos-client

MKowalski8 mentioned this pull request May 20, 2026

Replace precompiled ledger app binary with CI build foundry-rs/starknet-foundry#4323

Open

5 tasks

MKowalski8 added 2 commits May 20, 2026 11:59

Bump speculos-client version

30ec1a3

Update apdu serialization

4524ecc

MKowalski8 force-pushed the mkowalski/ledger-app-build branch from fcf3569 to 4524ecc Compare May 20, 2026 10:00

Remove version pin

3d14c0c

MKowalski8 marked this pull request as ready for review May 21, 2026 11:45

MKowalski8 requested a review from a team as a code owner May 21, 2026 11:45

Update comment

633e7d5

MKowalski8 requested review from ddoktorski and franciszekjob May 21, 2026 11:52

MKowalski8 changed the title ~~Replace precompiled ledger app binary with CI build~~ Replace precompiled ledger app binary with CI build and fork speculos-client with support for 2.4.0 starknet app May 21, 2026

ddoktorski reviewed May 25, 2026

View reviewed changes

franciszekjob reviewed May 25, 2026

View reviewed changes

Comment thread .github/workflows/test.yaml Outdated

Comment thread utils/speculos-client/src/starknet_app.rs Outdated

MKowalski8 added 5 commits May 25, 2026 17:57

Remove speculos-client version

cdbddfb

Pin to commit in workflow

2709c63

Fix comment

99cc60e

Fix timeout

462f789

Add timeout test

dc7c13c

MKowalski8 force-pushed the mkowalski/ledger-app-build branch from bb6f02c to dc7c13c Compare May 27, 2026 14:00

Timeout improvments

2018bd3

MKowalski8 force-pushed the mkowalski/ledger-app-build branch from ff2b8ba to 0468ddb Compare May 28, 2026 08:26

MKowalski8 force-pushed the mkowalski/ledger-app-build branch 2 times, most recently from 6f297a8 to a8f536c Compare May 28, 2026 09:50

Handle race conditions better

48b74b7

MKowalski8 force-pushed the mkowalski/ledger-app-build branch from a8f536c to 48b74b7 Compare May 28, 2026 10:12

Fix accounts tests

eab06b0

MKowalski8 force-pushed the mkowalski/ledger-app-build branch from a8ee712 to eab06b0 Compare May 28, 2026 10:31

MKowalski8 added 2 commits May 28, 2026 13:47

Optimize CI job

6aa5414

Speed up ledger tests

a164636

MKowalski8 force-pushed the mkowalski/ledger-app-build branch from 7dd6202 to a164636 Compare May 28, 2026 13:10

MKowalski8 requested review from ddoktorski and franciszekjob May 28, 2026 13:29

ddoktorski reviewed May 29, 2026

View reviewed changes

Review improvements

38f3d2c

MKowalski8 requested a review from ddoktorski June 1, 2026 13:56

		if line.contains("launcher: using default app name & version")
		\|\| line.contains("[*] Env app version:")

Conversation

MKowalski8 commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Introduced changes

Checklist

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MKowalski8 May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MKowalski8 May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MKowalski8 May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MKowalski8 commented May 19, 2026 •

edited

Loading

MKowalski8 May 25, 2026 •

edited

Loading

MKowalski8 May 25, 2026 •

edited

Loading

MKowalski8 May 29, 2026 •

edited

Loading