Skip to content

Support RPC 0.8.1 #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 91 commits into from
Apr 18, 2025
Merged

Support RPC 0.8.1 #220

merged 91 commits into from
Apr 18, 2025

Conversation

@franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Oct 24, 2024 •
edited
Loading

Describe your changes

Add support for RPC 0.8.1

  • starknet_getStorageProof
    • Add StarknetGetStorageProofResponse, StarknetGlobalRoots, StarknetContractsProof, StarknetContractLeafData, StarknetNodeHashToNodeMappingItem, StarknetBinaryNode, StarknetEdgeNode, StarknetContractsStorageKey structs
    • Add getStorageProof method in StarknetRequest
  • starknet_getMessagesStatus
    • Add StarknetMessageStatus struct
    • Add getMessagesStatus method in StarknetRequest
  • Adapt execution resources to new receipt
    • StarknetAccountProtocol:
      • signDeployAccountV3 has now resourceBounds param instead of l1ResourceBounds
    • StarknetInvokeParamsV3, StarknetDeployAccountParamsV3, StarknetOptionalInvokeParamsV3:
      • Change l1ResourceBounds param to resourceBounds in constructors
    • StarknetFeeEstimate :
      • rename gasConsumed to l1GasConsumed
      • rename gasPrice to l1GasPrice
      • rename dataGasPrice to l1DataGasPrice
      • rename dataGasConsumed to l1DataGasConsumed
      • add l2GasConsumed, l2GasPrice fields
    • Update StarknetResources protocol to have only l1Gas and l2Gas fields
    • Update StarknetExecutionResources fields
    • Remove StarknetDataAvailability and StarknetComputationResources
    • Add StarknetInnerCallExecutionResources
    • Remove constructor accepting only l1Gas in StarknetResourceBoundsMapping
    • Rename computationResources to executionResources in StarknetFunctionInvocation and change its type to StarknetInnerCallExecutionResources instead of StarknetComputationResources
  • Add failureReason to StarknetGetTransactionStatusResponse
  • Add isReverted to StarknetFunctionInvocation

Linked issues

Closes #219

Breaking changes

  • This issue contains breaking changes
  • Not compatible with JSON-RPC 0.7.0 spec
  • Use resourceBounds instead of l1ResourceBounds param
  • StarknetComputationResources has been removed; StarknetExecutionResources and StarknetFeeEstimate have been updated
  • StarknetFeeEstimate gas values are now of type UInt64AsHex (for amounts) and UInt128AsHex (for prices)

@franciszekjob franciszekjob marked this pull request as draft October 24, 2024 22:45
@franciszekjob franciszekjob changed the title Support JSON RPC 0.8.0 Support RPC 0.8.0 Oct 25, 2024
@franciszekjob franciszekjob removed the request for review from DelevoXDG October 28, 2024 08:33
DelevoXDG
DelevoXDG reviewed Oct 28, 2024
View reviewed changes
@franciszekjob franciszekjob changed the title Support RPC 0.8.0 Support RPC 0.8.1 Apr 14, 2025
franciszekjob
franciszekjob commented Apr 14, 2025
View reviewed changes
Tests/StarknetTests/Utils/DevnetClient/DevnetClient.swift
Comment on lines -64 to -72
func createAccount(
name: String,
classHash: Felt = DevnetClientConstants.accountContractClassHash,
salt: Felt? = .zero
) async throws -> CreateAccountResult {
try await createAccount(
name: name,
classHash: classHash,
salt: salt
Copy link
Collaborator Author

@franciszekjob franciszekjob Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Can be removed as it was redundant

DelevoXDG
DelevoXDG reviewed Apr 16, 2025
View reviewed changes
franciszekjob
franciszekjob commented Apr 17, 2025
View reviewed changes
Tests/StarknetTests/Crypto/FeeEstimateTests.swift
Copy link
Collaborator Author

@franciszekjob franciszekjob Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I refactored these tests (similar as in JVM), there's not need to test multiplication in the same way multiple times. Should make more sense now.

@franciszekjob franciszekjob requested a review from DelevoXDG April 17, 2025 16:19
DelevoXDG
DelevoXDG reviewed Apr 17, 2025
View reviewed changes
@franciszekjob franciszekjob requested a review from DelevoXDG April 17, 2025 18:27
DelevoXDG
DelevoXDG approved these changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@DelevoXDG DelevoXDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franciszekjob franciszekjob merged commit eb067b6 into main Apr 18, 2025
1 check passed
@franciszekjob franciszekjob deleted the feat/219-rpc-0.8.0 branch April 18, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DelevoXDG DelevoXDG DelevoXDG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support JSON-RPC v0.8.0

3 participants

@franciszekjob @DelevoXDG