[WIP] http4s - migrate from Blaze to Ember#4185
[WIP] http4s - migrate from Blaze to Ember#4185ivan-klass wants to merge 32 commits intosoftwaremill:masterfrom
Conversation
ivan-klass
force-pushed
the
http4s-migrate-to-ember
branch
from
16a531e to
cd1ce53
Compare
ivan-klass
force-pushed
the
http4s-migrate-to-ember
branch
2 times, most recently
from
088bbfa to
6aa2b66
Compare
ivan-klass
force-pushed
the
http4s-migrate-to-ember
branch
2 times, most recently
from
f0b3c83 to
57c2fa6
Compare
|
Oh nice, I was worried you abandoned the PR ;) |
|
Will wait for #4267 first |
ivan-klass
changed the title
|
@ivan-klass sure thing, done :) |
ivan-klass
force-pushed
the
http4s-migrate-to-ember
branch
from
3fe8b8e to
8b5ea8a
Compare
ivan-klass
changed the title
|
To whom it may concern: ember builder doesn't have an option for a specific execution context, so test request handling is not in the global one as it was before. It seems like race conditions are observed when dealing with some web-socket tests. |
|
@ivan-klass sorry for the delay - the global EC was used before only because it was the easiest one to obtain ;). I don't think there's anything in the tests that would rely on the global one being used: each server should be independent anyway, regardless on the thread pool on which tasks/futures are scheduled. So I would look for causes of the exceptions elsewhere, unfortunately. |
|
Then there might be a bug in http4-ember then... I'll try to dig in and reproduce when I have time |
ivan-klass
force-pushed
the
http4s-migrate-to-ember
branch
from
195128a to
7b7eda3
Compare
2 participants
Ember seems to be more modern and especially better supported in terms of cross-platform builds